Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35c9bb85 authored by lesl's avatar lesl Committed by Les Lee
Browse files

wifi: Use new API for data usage function 

For mobile, a old API: buildTemplateMobileAll doesn't includes the
merged wifi network, call the new API: buildTemplateCarrierMetered
to replace the old one.

PS: Not only usage functionality but also apply to network policy
control since the default policy is changing to use
new API: buildTemplateCarrier now.

Test: atest -c DataUsageControllerTest
Test: atest -c NetworkCycleDataForUidLoaderTest
Test: atest -c NetworkPolicyEditorTest
Test: Manual Test, modify the mobile usage warming and limit bytes and
      check the data via adb shell dumpsys netpolicy
Bug: 176396812
Merged-In: I1c7da4a819e45009efe5ba2b80e1526ce6b04e27
Change-Id: I1c7da4a819e45009efe5ba2b80e1526ce6b04e27
parent b8b282e5

packages/SettingsLib/src/com/android/settingslib/net/DataUsageUtils.java

+2 −1
Original line number Diff line number Diff line
@@ -73,6 +73,7 @@ public class DataUsageUtils { 


    private static NetworkTemplate getMobileTemplateForSubId(

            TelephonyManager telephonyManager, int subId) {

        return NetworkTemplate.buildTemplateMobileAll(telephonyManager.getSubscriberId(subId));

        return NetworkTemplate.buildTemplateCarrierMetered(

                telephonyManager.getSubscriberId(subId));

    }

}

packages/SettingsLib/tests/integ/src/com/android/settingslib/utils/NetworkPolicyEditorTest.java

+1 −1
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ public class NetworkPolicyEditorTest { 


    @Before

    public void setUp() {

        mNetworkTemplate = NetworkTemplate.buildTemplateMobileAll("123456789123456");

        mNetworkTemplate = NetworkTemplate.buildTemplateCarrierMetered("123456789123456");

        NetworkPolicyManager policyManager = NetworkPolicyManager.from(InstrumentationRegistry

                .getContext());

        mNetworkPolicyEditor = new NetworkPolicyEditor(policyManager);

packages/SettingsLib/tests/robotests/src/com/android/settingslib/net/DataUsageControllerTest.java

+2 −2
Original line number Diff line number Diff line
@@ -87,8 +87,8 @@ public class DataUsageControllerTest { 
        ShadowSubscriptionManager.setDefaultDataSubscriptionId(mDefaultSubscriptionId);

        doReturn(SUB_ID).when(mTelephonyManager).getSubscriberId();



        mNetworkTemplate = NetworkTemplate.buildTemplateMobileAll(SUB_ID);

        mNetworkTemplate2 = NetworkTemplate.buildTemplateMobileAll(SUB_ID_2);

        mNetworkTemplate = NetworkTemplate.buildTemplateCarrierMetered(SUB_ID);

        mNetworkTemplate2 = NetworkTemplate.buildTemplateCarrierMetered(SUB_ID_2);

        mWifiNetworkTemplate = NetworkTemplate.buildTemplateWifi(

                NetworkTemplate.WIFI_NETWORKID_ALL, null);

    }

packages/SettingsLib/tests/robotests/src/com/android/settingslib/net/NetworkCycleDataForUidLoaderTest.java

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ public class NetworkCycleDataForUidLoaderTest { 
        when(mContext.getSystemService(Context.NETWORK_POLICY_SERVICE))

                .thenReturn(mNetworkPolicyManager);

        when(mNetworkPolicyManager.getNetworkPolicies()).thenReturn(new NetworkPolicy[0]);

        mNetworkTemplate = NetworkTemplate.buildTemplateMobileAll(SUB_ID);

        mNetworkTemplate = NetworkTemplate.buildTemplateCarrierMetered(SUB_ID);

    }



    @Test