Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35503414 authored by Tyler Gunn's avatar Tyler Gunn
Browse files

Mark EXTRA_PLAY_CALL_RECORDING_TONE as deprecated. 

This constant was never actually used and serves no purpose any more.
This was used to detect apps that tried to record a call by recording the
device mic hoping to pick up the call audio from the earpiece.  This is
no longer allowed by audio policies.   This extra was set based on a
carrier config key that was never actually used by any carriers anyways.
Removing to clean up dead/useless code.

Flag: com.android.server.telecom.flags.telecom_resolve_hidden_dependencies
Test: Run unit/cts tests.
Bug: 308017600
Change-Id: Id43b8fcffa7c98b8b907116b54acd693ecbcd4e7
parent 3beaa244

core/api/system-current.txt

+1 −1
Original line number Diff line number Diff line
@@ -14196,7 +14196,7 @@ package android.telecom { 
    field public static final int CAPABILITY_EMERGENCY_PREFERRED = 8192; // 0x2000

    field public static final int CAPABILITY_EMERGENCY_VIDEO_CALLING = 512; // 0x200

    field public static final int CAPABILITY_MULTI_USER = 32; // 0x20

    field public static final String EXTRA_PLAY_CALL_RECORDING_TONE = "android.telecom.extra.PLAY_CALL_RECORDING_TONE";

    field @Deprecated @FlaggedApi("com.android.server.telecom.flags.telecom_resolve_hidden_dependencies") public static final String EXTRA_PLAY_CALL_RECORDING_TONE = "android.telecom.extra.PLAY_CALL_RECORDING_TONE";

    field @FlaggedApi("com.android.server.telecom.flags.telecom_resolve_hidden_dependencies") public static final String EXTRA_SKIP_CALL_FILTERING = "android.telecom.extra.SKIP_CALL_FILTERING";

    field public static final String EXTRA_SORT_ORDER = "android.telecom.extra.SORT_ORDER";

  }

telecomm/java/android/telecom/PhoneAccount.java

+7 −0
Original line number Diff line number Diff line
@@ -175,8 +175,15 @@ public final class PhoneAccount implements Parcelable { 
     * <p>

     * The call recording tone is a 1400 hz tone which repeats every 15 seconds while recording is

     * in progress.

     *

     * @deprecated this API was only intended to prevent call recording via the microphone by an app

     * while in a phone call.  Audio policies no longer make this possible.  Further, this API was

     * never actually used.  Call recording solutions integrated in an OEM dialer app must use

     * appropriate recording signals to inform the caller/callee of the recording.

     * @hide

     */

    @FlaggedApi(com.android.server.telecom.flags.Flags.FLAG_TELECOM_RESOLVE_HIDDEN_DEPENDENCIES)

    @Deprecated

    @SystemApi

    public static final String EXTRA_PLAY_CALL_RECORDING_TONE =

            "android.telecom.extra.PLAY_CALL_RECORDING_TONE";

telephony/java/android/telephony/CarrierConfigManager.java

+1 −0
Original line number Diff line number Diff line
@@ -420,6 +420,7 @@ public class CarrierConfigManager { 
     * <p>

     * Note: This requires the Telephony config_supports_telephony_audio_device overlay to be true

     * in order to work.

     * @deprecated this functionality was never used and is no longer supported.

     * @hide

     */

    public static final String KEY_PLAY_CALL_RECORDING_TONE_BOOL = "play_call_recording_tone_bool";