Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 33f17585 authored by Philip P. Moltmann's avatar Philip P. Moltmann
Browse files

Make Print notification intent immutable 

They are not meant fro modification.

Test: Clicked on a notification to follow the intent
Fixes: 156009434
Change-Id: I04abfb4def70f05b30a2a35c8889c5a1a6857de0
parent fc663142

packages/PrintSpooler/src/com/android/printspooler/model/NotificationController.java

+5 −3
Original line number Diff line number Diff line
@@ -276,21 +276,23 @@ final class NotificationController { 
            intent.putExtra(EXTRA_PRINT_JOB_ID, printJobId.flattenToString());

            intent.setData(Uri.fromParts("printjob", printJobId.flattenToString(), null));

        }

        return PendingIntent.getActivity(mContext, 0, intent, 0);

        return PendingIntent.getActivity(mContext, 0, intent, PendingIntent.FLAG_IMMUTABLE);

    }



    private PendingIntent createCancelIntent(PrintJobInfo printJob) {

        Intent intent = new Intent(mContext, NotificationBroadcastReceiver.class);

        intent.setAction(INTENT_ACTION_CANCEL_PRINTJOB + "_" + printJob.getId().flattenToString());

        intent.putExtra(EXTRA_PRINT_JOB_ID, printJob.getId());

        return PendingIntent.getBroadcast(mContext, 0, intent, PendingIntent.FLAG_ONE_SHOT);

        return PendingIntent.getBroadcast(mContext, 0, intent,

                PendingIntent.FLAG_ONE_SHOT | PendingIntent.FLAG_IMMUTABLE);

    }



    private PendingIntent createRestartIntent(PrintJobId printJobId) {

        Intent intent = new Intent(mContext, NotificationBroadcastReceiver.class);

        intent.setAction(INTENT_ACTION_RESTART_PRINTJOB + "_" + printJobId.flattenToString());

        intent.putExtra(EXTRA_PRINT_JOB_ID, printJobId);

        return PendingIntent.getBroadcast(mContext, 0, intent, PendingIntent.FLAG_ONE_SHOT);

        return PendingIntent.getBroadcast(mContext, 0, intent,

                PendingIntent.FLAG_ONE_SHOT | PendingIntent.FLAG_IMMUTABLE);

    }



    private static boolean shouldNotifyForState(int state) {