Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 33bae888 authored by Andrew Scull's avatar Andrew Scull
Browse files

WebViewUpdater: make lock object final.

Synchronizing on non-final fields is not safe: if the field is ever
updated, different threads may end up locking on different objects.

Bug: 38441224
Test: Build
Change-Id: Icc5dbfbaeeb276504a789d3a1c81af82e5128c9b
parent 74fa79e6
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ class WebViewUpdater {
    // The WebView package currently in use (or the one we are preparing).
    private PackageInfo mCurrentWebViewPackage = null;

    private Object mLock = new Object();
    private final Object mLock = new Object();

    WebViewUpdater(Context context, SystemInterface systemInterface) {
        mContext = context;