Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 33032172 authored by Chris Li's avatar Chris Li Committed by Android (Google) Code Review
Browse files

Merge "Reset override config when clearSizeCompat" into sc-v2-dev

parents 74c94435 a9c24f5e

services/core/java/com/android/server/wm/ActivityRecord.java

+2 −1
Original line number Diff line number Diff line
@@ -7368,7 +7368,8 @@ final class ActivityRecord extends WindowToken implements WindowManagerService.A 
        mSizeCompatBounds = null;

        mCompatDisplayInsets = null;



        onRequestedOverrideConfigurationChanged(getRequestedOverrideConfiguration());

        // Clear config override in #updateCompatDisplayInsets().

        onRequestedOverrideConfigurationChanged(EMPTY);

    }



    @Override

services/tests/wmtests/src/com/android/server/wm/SizeCompatTests.java

+24 −0
Original line number Diff line number Diff line
@@ -76,6 +76,7 @@ import android.content.pm.ActivityInfo; 
import android.content.pm.ActivityInfo.ScreenOrientation;

import android.content.res.Configuration;

import android.graphics.Rect;

import android.os.UserHandle;

import android.platform.test.annotations.Presubmit;

import android.provider.DeviceConfig;

import android.provider.DeviceConfig.Properties;
@@ -2181,6 +2182,29 @@ public class SizeCompatTests extends WindowTestsBase { 
                .computeAspectRatio(sizeCompatAppBounds), delta);

    }



    @Test

    public void testClearSizeCompat_resetOverrideConfig() {

        final int origDensity = 480;

        final int newDensity = 520;

        final DisplayContent display = new TestDisplayContent.Builder(mAtm, 600, 800)

                .setDensityDpi(origDensity)

                .build();

        setUpApp(display);

        prepareUnresizable(mActivity, -1.f /* maxAspect */, SCREEN_ORIENTATION_PORTRAIT);



        // Activity should enter size compat with old density after display density change.

        display.setForcedDensity(newDensity, UserHandle.USER_CURRENT);



        assertScaled();

        assertEquals(origDensity, mActivity.getConfiguration().densityDpi);



        // Activity should exit size compat with new density.

        mActivity.clearSizeCompatMode();



        assertFitted();

        assertEquals(newDensity, mActivity.getConfiguration().densityDpi);

    }



    private void assertHorizontalPositionForDifferentDisplayConfigsForLandscapeActivity(

            float letterboxHorizontalPositionMultiplier) {

        // Set up a display in landscape and ignoring orientation request.