Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32d124e0 authored by Justin Weir's avatar Justin Weir
Browse files

Remove logging present in an ANR stack trace 

The logging was added for b/245441667, which is fixed, and the
toString call was already doing too much work for a log buffer
anyway.

Fixes: 288791416
Bug: 245441667
Test: presubmits are sufficient
Change-Id: I3ee11d833a860c5259957bbc846d2b342223105a
parent f58e1e47

packages/SystemUI/src/com/android/systemui/shade/NotificationShadeWindowControllerImpl.java

+0 −1
Original line number Diff line number Diff line
@@ -480,7 +480,6 @@ public class NotificationShadeWindowControllerImpl implements NotificationShadeW 


    private void applyWindowLayoutParams() {

        if (mDeferWindowLayoutParams == 0 && mLp != null && mLp.copyFrom(mLpChanged) != 0) {

            mLogger.logApplyingWindowLayoutParams(mLp);

            Trace.beginSection("updateViewLayout");

            mWindowManager.updateViewLayout(mWindowRootView, mLp);

            Trace.endSection();

packages/SystemUI/src/com/android/systemui/shade/ShadeWindowLogger.kt

+1 −11
Original line number Diff line number Diff line
@@ -16,14 +16,13 @@ 


package com.android.systemui.shade



import android.view.WindowManager

import com.android.systemui.log.dagger.ShadeWindowLog

import com.android.systemui.log.ConstantStringsLogger

import com.android.systemui.log.ConstantStringsLoggerImpl

import com.android.systemui.log.LogBuffer

import com.android.systemui.log.core.LogLevel

import com.android.systemui.log.core.LogLevel.DEBUG

import com.android.systemui.log.core.LogMessage

import com.android.systemui.log.dagger.ShadeWindowLog

import javax.inject.Inject



private const val TAG = "systemui.shadewindow"
@@ -31,15 +30,6 @@ private const val TAG = "systemui.shadewindow" 
class ShadeWindowLogger @Inject constructor(@ShadeWindowLog private val buffer: LogBuffer) :

    ConstantStringsLogger by ConstantStringsLoggerImpl(buffer, TAG) {



    fun logApplyingWindowLayoutParams(lp: WindowManager.LayoutParams) {

        buffer.log(

            TAG,

            DEBUG,

            { str1 = lp.toString() },

            { "Applying new window layout params: $str1" }

        )

    }



    fun logNewState(state: Any) {

        buffer.log(

            TAG,