Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32d07dce authored by Chad Brubaker's avatar Chad Brubaker
Browse files

Disallow sharedUserId in Ephemeral apps 

Test: adb install --ephemeral apk fails with a shareduid defined
Change-Id: I2e03d89b983b99e35ea799618f6830b309c09b49
parent 7f9d210e

core/java/android/content/pm/PackageParser.java

+5 −0
Original line number Original line Diff line number Diff line
@@ -1696,6 +1696,11 @@ public class PackageParser { 
        String str = sa.getNonConfigurationString(

        String str = sa.getNonConfigurationString(

                com.android.internal.R.styleable.AndroidManifest_sharedUserId, 0);

                com.android.internal.R.styleable.AndroidManifest_sharedUserId, 0);

        if (str != null && str.length() > 0) {

        if (str != null && str.length() > 0) {

            if ((flags & PARSE_IS_EPHEMERAL) != 0) {

                outError[0] = "sharedUserId not allowed in ephemeral application";

                mParseError = PackageManager.INSTALL_PARSE_FAILED_BAD_SHARED_USER_ID;

                return null;

            }

            String nameError = validateName(str, true, false);

            String nameError = validateName(str, true, false);

            if (nameError != null && !"android".equals(pkg.packageName)) {

            if (nameError != null && !"android".equals(pkg.packageName)) {

                outError[0] = "<manifest> specifies bad sharedUserId name \""

                outError[0] = "<manifest> specifies bad sharedUserId name \""