Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 322dd1f6 authored by Jernej Virag's avatar Jernej Virag
Browse files

Fix memory leak in shade service list dialog 

RecyclerView adapters hold reference to RVs they were added in. Since we
reuse the adapter, we leak the whole RV view hiearchy on every dialog
open. Clear the adapter on dialog close which also clears the references
in RV#setAdapterInternal.

Bug: 424097770
Test: tested on Panther, ran tests
Flag: EXEMPT bugfix
Change-Id: I124fe6a333c7bb4a63cb06592faa08814562316e
parent 31bfbdb4

packages/SystemUI/src/com/android/systemui/qs/FgsManagerController.kt

+4 −0
Original line number Diff line number Diff line
@@ -410,6 +410,10 @@ constructor( 
                    newChangesSinceDialogWasDismissed = false

                    synchronized(lock) {

                        this.dialog = null

                        // Adapters keep references to RV they're added to and

                        // we need to explicitly clear that reference via setAdapter

                        // to avoid a leak.

                        recyclerView.adapter = null

                        updateAppItemsLocked()

                    }

                    onDialogDismissedListeners.forEach {