Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 322a4baf authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Automerger Merge Worker
Browse files

Merge "Remove obsolete/infeasible TODOs" into rvc-dev am: d5729ebc am:... 

Merge "Remove obsolete/infeasible TODOs" into rvc-dev am: d5729ebc am: 41978ed0 am: 7203b971 am: 94fad652

Change-Id: I9163c87551625da1062beb855df6bdb08e1afb82
parents 11cd2fda 94fad652

cmds/statsd/src/logd/LogEvent.h

+0 −3
Original line number Original line Diff line number Diff line
@@ -218,9 +218,6 @@ private: 
     * The below three variables are only valid during the execution of

     * The below three variables are only valid during the execution of

     * parseBuffer. There are no guarantees about the state of these variables

     * parseBuffer. There are no guarantees about the state of these variables

     * before/after.

     * before/after.

     *

     * TODO (b/150312423): These shouldn't be member variables. We should pass

     * them around as parameters.

     */

     */

    uint8_t* mBuf;

    uint8_t* mBuf;

    uint32_t mRemainingLen; // number of valid bytes left in the buffer being parsed

    uint32_t mRemainingLen; // number of valid bytes left in the buffer being parsed

cmds/statsd/src/shell/ShellSubscriber.cpp

+0 −1
Original line number Original line Diff line number Diff line
@@ -152,7 +152,6 @@ void ShellSubscriber::startPull(int64_t myToken) { 
                mPullerMgr->Pull(pullInfo.mPullerMatcher.atom_id(), uids, &data);

                mPullerMgr->Pull(pullInfo.mPullerMatcher.atom_id(), uids, &data);

                VLOG("pulled %zu atoms with id %d", data.size(), pullInfo.mPullerMatcher.atom_id());

                VLOG("pulled %zu atoms with id %d", data.size(), pullInfo.mPullerMatcher.atom_id());





                // TODO(b/150969574): Don't write to a pipe while holding a lock.

                if (!writePulledAtomsLocked(data, pullInfo.mPullerMatcher)) {

                if (!writePulledAtomsLocked(data, pullInfo.mPullerMatcher)) {

                    mSubscriptionInfo->mClientAlive = false;

                    mSubscriptionInfo->mClientAlive = false;

                    mSubscriptionShouldEnd.notify_one();

                    mSubscriptionShouldEnd.notify_one();