Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3227aabe authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix/suppress statsd google-explicit-constructor warnings 

* Add explicit to conversion constructors/operators
* Remove redundant explicit of copy constructors

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: Ifd0ca9a1afe4a2cb0456a36c69bee1633af5a93a
parent bcf293c6

cmds/statsd/src/anomaly/AlarmMonitor.h

+1 −1
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ namespace statsd { 
 * Timestamps are in seconds since epoch in a uint32, so will fail in year 2106.

 */

struct InternalAlarm : public RefBase {

    InternalAlarm(uint32_t timestampSec) : timestampSec(timestampSec) {

    explicit InternalAlarm(uint32_t timestampSec) : timestampSec(timestampSec) {

    }



    const uint32_t timestampSec;

cmds/statsd/src/condition/ConditionWizard.h

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ namespace statsd { 
class ConditionWizard : public virtual android::RefBase {

public:

    ConditionWizard(){};  // for testing

    ConditionWizard(std::vector<sp<ConditionTracker>>& conditionTrackers)

    explicit ConditionWizard(std::vector<sp<ConditionTracker>>& conditionTrackers)

        : mAllConditions(conditionTrackers){};



    virtual ~ConditionWizard(){};

cmds/statsd/src/config/ConfigKey.h

+1 −1
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ using std::string; 
class ConfigKey {

public:

    ConfigKey();

    explicit ConfigKey(const ConfigKey& that);

    ConfigKey(const ConfigKey& that);

    ConfigKey(int uid, const int64_t& id);

    ~ConfigKey();

cmds/statsd/src/external/ResourceHealthManagerPuller.h

+1 −1
Original line number Diff line number Diff line
@@ -28,7 +28,7 @@ namespace statsd { 
 */

class ResourceHealthManagerPuller : public StatsPuller {

public:

    ResourceHealthManagerPuller(int tagId);

    explicit ResourceHealthManagerPuller(int tagId);

    bool PullInternal(vector<std::shared_ptr<LogEvent>>* data) override;

};

cmds/statsd/src/external/StatsCompanionServicePuller.h

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ namespace statsd { 


class StatsCompanionServicePuller : public StatsPuller {

public:

    StatsCompanionServicePuller(int tagId);

    explicit StatsCompanionServicePuller(int tagId);

    bool PullInternal(vector<std::shared_ptr<LogEvent> >* data) override;



    void SetStatsCompanionService(sp<IStatsCompanionService> statsCompanionService) override;