Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32172572 authored by wilsonshih's avatar wilsonshih
Browse files

Remove flag exclude_non_main_window_from_snapshot 

Fix: 437840260
Flag: EXEMPT flag removal
Test: build
Change-Id: I36d0e79bf16509f731fb26d5767c3bcb5f1b8972
parent e6b3b930

core/java/android/window/flags/windowing_frontend.aconfig

+0 −11
Original line number Original line Diff line number Diff line
@@ -384,17 +384,6 @@ flag { 
    }

    }

}

}





flag {

    name: "exclude_non_main_window_from_snapshot"

    namespace: "windowing_frontend"

    description: "Exclude non-main windows during their removal from being captured in the snapshot."

    bug: "412295455"

    is_fixed_read_only: true

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

flag {

    name: "predictive_back_delay_wm_transition"

    name: "predictive_back_delay_wm_transition"

    namespace: "windowing_frontend"

    namespace: "windowing_frontend"

services/core/java/com/android/server/wm/AbsAppSnapshotController.java

+5 −7
Original line number Original line Diff line number Diff line
@@ -308,13 +308,11 @@ abstract class AbsAppSnapshotController<TYPE extends WindowContainer<?>, 
        if (navWindow != null) {

        if (navWindow != null) {

            excludeSurfaces.add(navWindow.getSurfaceControl());

            excludeSurfaces.add(navWindow.getSurfaceControl());

        }

        }

        if (Flags.excludeNonMainWindowFromSnapshot()) {

        source.forAllWindows(w -> {

        source.forAllWindows(w -> {

            if (w.mAnimatingExit && !w.mRemoved && w.mAttrs.type != TYPE_BASE_APPLICATION) {

            if (w.mAnimatingExit && !w.mRemoved && w.mAttrs.type != TYPE_BASE_APPLICATION) {

                excludeSurfaces.add(w.getSurfaceControl());

                excludeSurfaces.add(w.getSurfaceControl());

            }

            }

        }, true /* traverseTopToBottom */);

        }, true /* traverseTopToBottom */);

        }

        final SurfaceControl[] excludeLayers =

        final SurfaceControl[] excludeLayers =

                excludeSurfaces.toArray(new SurfaceControl[excludeSurfaces.size()]);

                excludeSurfaces.toArray(new SurfaceControl[excludeSurfaces.size()]);

        builder.setHasImeSurface(!excludeIme && imeWindow != null && imeWindow.isVisible());

        builder.setHasImeSurface(!excludeIme && imeWindow != null && imeWindow.isVisible());

services/core/java/com/android/server/wm/WindowState.java

+1 −2
Original line number Original line Diff line number Diff line
@@ -2379,8 +2379,7 @@ class WindowState extends WindowContainer<WindowState> implements WindowManagerP 
                    mActivityRecord != null && mActivityRecord.inTransition(),

                    mActivityRecord != null && mActivityRecord.inTransition(),

                    Debug.getCallers(6));

                    Debug.getCallers(6));





            if (Flags.excludeNonMainWindowFromSnapshot()

            if (mAttrs.type != TYPE_BASE_APPLICATION && mHasSurface

                    && mAttrs.type != TYPE_BASE_APPLICATION && mHasSurface

                    && mActivityRecord != null && !mActivityRecord.isVisibleRequested()

                    && mActivityRecord != null && !mActivityRecord.isVisibleRequested()

                    && mWinAnimator.getShown()) {

                    && mWinAnimator.getShown()) {

                // Only remove the activity snapshot, because the user might still want to see the

                // Only remove the activity snapshot, because the user might still want to see the