Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 315433ca authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Improve the use of pointer" into main

parents 5d37481b bb99f502
Loading
Loading
Loading
Loading
+6 −3
Original line number Diff line number Diff line
@@ -1023,16 +1023,19 @@ static void Image_getLockedImage(JNIEnv* env, jobject thiz, LockedImage *image)
        return;
    }

    // Maintain a StrongPointer so that the GraphicBuffer isn't destroyed when the
    // StrongPointer in lockImageFromBuffer goes out of scope.
    sp<GraphicBuffer> bufferSp(buffer);
    // ImageWriter doesn't use crop by itself, app sets it, use the no crop version.
    const Rect noCrop(buffer->width, buffer->height);
    const Rect noCrop(bufferSp->width, bufferSp->height);
    status_t res = lockImageFromBuffer(
            buffer, GRALLOC_USAGE_SW_WRITE_OFTEN, noCrop, fenceFd, image);
            bufferSp, GRALLOC_USAGE_SW_WRITE_OFTEN, noCrop, fenceFd, image);
    // Clear the fenceFd as it is already consumed by lock call.
    env->SetIntField(thiz, gSurfaceImageClassInfo.mNativeFenceFd, -1);
    if (res != OK) {
        jniThrowExceptionFmt(env, "java/lang/RuntimeException",
                "lock buffer failed for format 0x%x",
                buffer->getPixelFormat());
                bufferSp->getPixelFormat());
        return;
    }