Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3102fa42 authored by Benedict Wong's avatar Benedict Wong Committed by Gerrit Code Review
Browse files

Merge "Fix remove-before-add for IpSecService RefcountedResource"

parents ad2928ac ccfaa3c0
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -208,6 +208,7 @@ public class IpSecService extends IIpSecService.Stub {
                    mBinder.linkToDeath(this, 0);
                } catch (RemoteException e) {
                    binderDied();
                    e.rethrowFromSystemServer();
                }
            }
        }
+6 −5
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.server;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.fail;
import static org.mockito.Matchers.anyInt;
import static org.mockito.Matchers.anyObject;
import static org.mockito.Matchers.eq;
@@ -134,11 +135,11 @@ public class IpSecServiceRefcountedResourceTest {
        IBinder binderMock = mock(IBinder.class);
        doThrow(new RemoteException()).when(binderMock).linkToDeath(anyObject(), anyInt());

        RefcountedResource<IResource> refcountedResource = getTestRefcountedResource(binderMock);

        // Verify that cleanup is performed (Spy limitations prevent verification of method calls
        // for binder death scenario; check refcount to determine if cleanup was performed.)
        assertEquals(-1, refcountedResource.mRefCount);
        try {
            getTestRefcountedResource(binderMock);
            fail("Expected exception to propogate when binder fails to link to death");
        } catch (RuntimeException expected) {
        }
    }

    @Test