Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ffca5a0 authored by Sunny Goyal's avatar Sunny Goyal
Browse files

Adding permission check for dumping visible windows 

Bug: 157010495
Test: Verfied that 3P apps cant call this API
Change-Id: I0dee93c82d33152fc54b6784970103c82a8ba6ef
parent f13d436c

services/core/java/com/android/server/wm/WindowManagerShellCommand.java

+5 −0
Original line number Diff line number Diff line
@@ -351,6 +351,11 @@ public class WindowManagerShellCommand extends ShellCommand { 
    }



    private int runDumpVisibleWindowViews(PrintWriter pw) {

        if (!mInternal.checkCallingPermission(android.Manifest.permission.DUMP,

                "runDumpVisibleWindowViews()")) {

            throw new SecurityException("Requires DUMP permission");

        }



        try (ZipOutputStream out = new ZipOutputStream(getRawOutputStream())) {

            ArrayList<Pair<String, ByteTransferPipe>> requestList = new ArrayList<>();

            synchronized (mInternal.mGlobalLock) {