Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f924ae9 authored by Jordan Demeulenaere's avatar Jordan Demeulenaere
Browse files

Prevent extra brightness slider recompositions

See b/389985793#comment124 for details.

Bug: 389985793
Test: Manual, perfetto trace
Flag: com.android.systemui.qs_ui_refactor_compose_fragment
Change-Id: Id0496f04f0f18b6e6310e4890327434431b04672
parent ff5962db
Loading
Loading
Loading
Loading
+12 −9
Original line number Diff line number Diff line
@@ -258,15 +258,18 @@ fun ContentScope.QuickSettingsLayout(
                modifier = Modifier.padding(horizontal = QuickSettingsShade.Dimensions.Padding),
            )

            BrightnessSliderContainer(
                viewModel = viewModel.brightnessSliderViewModel,
                containerColors = ContainerColors.singleColor(OverlayShade.Colors.PanelBackground),
                modifier =
            Box(
                Modifier.systemGestureExclusionInShade(
                    enabled = { layoutState.transitionState is TransitionState.Idle }
                )
                        .fillMaxWidth(),
            ) {
                BrightnessSliderContainer(
                    viewModel = viewModel.brightnessSliderViewModel,
                    containerColors =
                        ContainerColors.singleColor(OverlayShade.Colors.PanelBackground),
                    modifier = Modifier.fillMaxWidth(),
                )
            }

            Box {
                GridAnchor()
+18 −16
Original line number Diff line number Diff line
@@ -747,24 +747,26 @@ constructor(
                        val BrightnessSlider =
                            @Composable {
                                AlwaysDarkMode {
                                    Box(
                                        Modifier.systemGestureExclusionInShade(
                                            enabled = {
                                                layoutState.transitionState is TransitionState.Idle
                                            }
                                        )
                                    ) {
                                        BrightnessSliderContainer(
                                        viewModel = containerViewModel.brightnessSliderViewModel,
                                            viewModel =
                                                containerViewModel.brightnessSliderViewModel,
                                            containerColors =
                                                ContainerColors(
                                                    Color.Transparent,
                                                    ContainerColors.defaultContainerColor,
                                                ),
                                        modifier =
                                            Modifier.systemGestureExclusionInShade(
                                                    enabled = {
                                                        layoutState.transitionState is
                                                            TransitionState.Idle
                                                    }
                                                )
                                                .fillMaxWidth(),
                                            modifier = Modifier.fillMaxWidth(),
                                        )
                                    }
                                }
                            }
                        val TileGrid =
                            @Composable {
                                Box {