Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 2f891f63 authored by Helen Qin's avatar Helen Qin
Browse files

Short term solution for the in-animation-dismissal-freeze bug.

Problem: dismissal right during the selector pop-up animation upon
activity launch will cause the activity to not exit properly and hence
freezes the Activity, causing an empty overlay on top of the RP ui.

Cause: race conditiond cause by the bottom sheet value update before the sheet is able to fully render once,
We listen for bottom sheet state changes (Expanded to Hidden) to properly exit
the activity, but in this case, there is no state change - the state is
always hidden.

Long-term solution: update the BottomSheet dependency. The current
BottomSheet compose dependency has known issues that force us into the
current hide-then-show initial setup. With the new BottomSheet sdk we
will be able to start up with expanded state and then any hidden state
will be a proper state change that can be captured. (24Q3)

Short-term solution: also monitor target value and close the activity
upon a target value change. This solves the freezes but closes the
activity in a much more clunky way (since we close upon target value
change, the closing animation can't run fully). (24Q2)

Test: local verification & planned for QA testing
Bug: 307525290
Change-Id: I3a32852b7554b69634dfe252a48c007af8f124dd
parent e86d1246
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment