Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f184df0 authored by Felipe Leme's avatar Felipe Leme
Browse files

Improved logging on Autofill Save. 

Test: looked at adb logcat while running CTS tests
Test: atest CtsAutoFillServiceTestCases

Bug: 70348203

Change-Id: I115d639dacaeb85792ddaab2465dd0187fd1d362
parent c9c82958

services/autofill/java/com/android/server/autofill/Session.java

+7 −4
Original line number Diff line number Diff line
@@ -926,7 +926,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState 


        final int flags = lastResponse.getFlags();

        if ((flags & FillResponse.FLAG_TRACK_CONTEXT_COMMITED) == 0) {

            if (sDebug) Slog.d(TAG, "logContextCommittedLocked(): ignored by flags " + flags);

            if (sVerbose) Slog.v(TAG, "logContextCommittedLocked(): ignored by flags " + flags);

            return;

        }
@@ -1404,7 +1404,10 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState 
                    }

                }



                if (sDebug) Slog.d(TAG, "Good news, everyone! All checks passed, show save UI!");

                if (sDebug) {

                    Slog.d(TAG, "Good news, everyone! All checks passed, show save UI for "

                            + id + "!");

                }



                // Use handler so logContextCommitted() is logged first

                mHandlerCaller.getHandler().post(() -> mService.logSaveShown(id, mClientState));
@@ -1428,7 +1431,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState 
        }

        // Nothing changed...

        if (sDebug) {

            Slog.d(TAG, "showSaveLocked(): with no changes, comes no responsibilities."

            Slog.d(TAG, "showSaveLocked(" + id +"): with no changes, comes no responsibilities."

                    + "allRequiredAreNotNull=" + allRequiredAreNotEmpty

                    + ", atLeastOneChanged=" + atLeastOneChanged);

        }
@@ -1943,7 +1946,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState 
        try {

            if (sVerbose) {

                Slog.v(TAG, "updateTrackedIdsLocked(): " + trackedViews + " => " + fillableIds

                        + " (triggering on " + saveTriggerId + ")");

                        + " triggerId: " + saveTriggerId + " saveOnFinish:" + saveOnFinish);

            }

            mClient.setTrackedViews(id, toArray(trackedViews), saveOnAllViewsInvisible,

                    saveOnFinish, toArray(fillableIds), saveTriggerId);