Merge "Handle invalid data during job loading." into rvc-dev (2ef87719) · Commits · e / os / android_frameworks_base

apex/jobscheduler/service/java/com/android/server/job/JobStore.java

+23 −3

Original line number	Diff line number	Diff line
		@@ -687,6 +687,10 @@ public final class JobStore {
		}
		} catch (XmlPullParserException \| IOException e) {
		Slog.wtf(TAG, "Error jobstore xml.", e);
		} catch (Exception e) {
		// Crashing at this point would result in a boot loop, so live with a general
		// Exception for system stability's sake.
		Slog.wtf(TAG, "Unexpected exception", e);
		} finally {
		if (mPersistInfo.countAllJobsLoaded < 0) { // Only set them once.
		mPersistInfo.countAllJobsLoaded = numJobs;
		@@ -817,6 +821,15 @@ public final class JobStore {
		} catch (NumberFormatException e) {
		Slog.d(TAG, "Error reading constraints, skipping.");
		return null;
		} catch (XmlPullParserException e) {
		Slog.d(TAG, "Error Parser Exception.", e);
		return null;
		} catch (IOException e) {
		Slog.d(TAG, "Error I/O Exception.", e);
		return null;
		} catch (IllegalArgumentException e) {
		Slog.e(TAG, "Constraints contained invalid data", e);
		return null;
		}
		parser.next(); // Consume </constraints>

		@@ -912,8 +925,14 @@ public final class JobStore {
		return null;
		}

		PersistableBundle extras = PersistableBundle.restoreFromXml(parser);
		final PersistableBundle extras;
		try {
		extras = PersistableBundle.restoreFromXml(parser);
		jobBuilder.setExtras(extras);
		} catch (IllegalArgumentException e) {
		Slog.e(TAG, "Persisted extras contained invalid data", e);
		return null;
		}
		parser.nextTag(); // Consume </extras>

		final JobInfo builtJob;
		@@ -959,7 +978,8 @@ public final class JobStore {
		return new JobInfo.Builder(jobId, cname);
		}

		private void buildConstraintsFromXml(JobInfo.Builder jobBuilder, XmlPullParser parser) {
		private void buildConstraintsFromXml(JobInfo.Builder jobBuilder, XmlPullParser parser)
		throws XmlPullParserException, IOException {
		String val;

		final String netCapabilities = parser.getAttributeValue(null, "net-capabilities");