Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e6e7a3c authored by Dan Sandler's avatar Dan Sandler Committed by Daniel Sandler
Browse files

Ensure callbacks removed when view detached. 

Fixes: 193414087
Test: atest SystemUITests
Test: examine heap dumps for SysuiStatusBarStateController$RankedListener instances
Change-Id: I052c823b266449208424322457adcfdb483a278d
parent a22f94bd

packages/SystemUI/src/com/android/keyguard/AnimatableClockController.java

+1 −3
Original line number Original line Diff line number Diff line
@@ -160,10 +160,8 @@ public class AnimatableClockController extends ViewController<AnimatableClockVie 
        mBroadcastDispatcher.unregisterReceiver(mLocaleBroadcastReceiver);

        mBroadcastDispatcher.unregisterReceiver(mLocaleBroadcastReceiver);

        mKeyguardUpdateMonitor.removeCallback(mKeyguardUpdateMonitorCallback);

        mKeyguardUpdateMonitor.removeCallback(mKeyguardUpdateMonitorCallback);

        mBatteryController.removeCallback(mBatteryCallback);

        mBatteryController.removeCallback(mBatteryCallback);

        if (!mView.isAttachedToWindow()) {

        mStatusBarStateController.removeCallback(mStatusBarStatePersistentListener);

        mStatusBarStateController.removeCallback(mStatusBarStatePersistentListener);

    }

    }

    }





    /** Animate the clock appearance */

    /** Animate the clock appearance */

    public void animateAppear() {

    public void animateAppear() {