Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d74fafd authored by Jorim Jaggi's avatar Jorim Jaggi
Browse files

Fix starting of animations 

We need to manually process the first animation frame as
mStartTime of ValueAnimator would only be set when processing
the next animation frame.

Test: go/wm-smoke
Test: Add some additional tracing about current playing time and
observe no delay.
Bug: 64674361
Change-Id: Iad753bfb7b86cfd57f265b5084a3d24f967dcaf3
parent b0fc817f

services/core/java/com/android/server/wm/SurfaceAnimationRunner.java

+9 −5
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.android.server.wm;



import static android.util.TimeUtils.NANOS_PER_MS;

import static android.view.Choreographer.CALLBACK_TRAVERSAL;

import static android.view.Choreographer.getSfInstance;
@@ -25,7 +26,6 @@ import android.animation.Animator; 
import android.animation.AnimatorListenerAdapter;

import android.animation.ValueAnimator;

import android.annotation.Nullable;

import android.os.SystemClock;

import android.util.ArrayMap;

import android.view.Choreographer;

import android.view.SurfaceControl;
@@ -144,10 +144,6 @@ class SurfaceAnimationRunner { 
            scheduleApplyTransaction();

        });



        if (a.mAnimSpec.canSkipFirstFrame()) {

            anim.setCurrentPlayTime(Choreographer.getFrameDelay());

        }



        anim.addListener(new AnimatorListenerAdapter() {

            @Override

            public void onAnimationStart(Animator animation) {
@@ -173,6 +169,14 @@ class SurfaceAnimationRunner { 
            }

        });

        anim.start();

        if (a.mAnimSpec.canSkipFirstFrame()) {

            // If we can skip the first frame, we start one frame later.

            anim.setCurrentPlayTime(mChoreographer.getFrameIntervalNanos() / NANOS_PER_MS);

        }



        // Immediately start the animation by manually applying an animation frame. Otherwise, the

        // start time would only be set in the next frame, leading to a delay.

        anim.doAnimationFrame(mChoreographer.getFrameTime());

        a.mAnim = anim;

        mRunningAnimations.put(a.mLeash, a);

    }