Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ccf4422 authored by Caitlin Shkuratov's avatar Caitlin Shkuratov
Browse files

[SB] Remove status_bar_use_repos_for_call_chip flag. 

This flag was launched in 24Q4, which has been released for a month.

Bug: 328584859
Flag: EXEMPT flag removal
Test: Post call notification -> verify call chip still appears
Change-Id: If3b0575b90cee6c766b829c5b40364a27de08d08
parent 33c2d333

packages/SystemUI/aconfig/systemui.aconfig

+0 −11
Original line number Diff line number Diff line
@@ -423,17 +423,6 @@ flag { 
    }

}



flag {

    name: "status_bar_use_repos_for_call_chip"

    namespace: "systemui"

    description: "Use repositories as the source of truth for call notifications shown as a chip in"

        "the status bar"

    bug: "328584859"

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

    name: "status_bar_call_chip_notification_icon"

    namespace: "systemui"

packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/phone/ongoingcall/OngoingCallControllerViaRepoTest.kt→packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/phone/ongoingcall/OngoingCallControllerTest.kt

+1 −5
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ import androidx.test.ext.junit.runners.AndroidJUnit4 
import androidx.test.filters.SmallTest

import com.android.systemui.Flags.FLAG_STATUS_BAR_CALL_CHIP_NOTIFICATION_ICON

import com.android.systemui.Flags.FLAG_STATUS_BAR_SCREEN_SHARING_CHIPS

import com.android.systemui.Flags.FLAG_STATUS_BAR_USE_REPOS_FOR_CALL_CHIP

import com.android.systemui.SysuiTestCase

import com.android.systemui.concurrency.fakeExecutor

import com.android.systemui.dump.DumpManager
@@ -42,7 +41,6 @@ import com.android.systemui.res.R 
import com.android.systemui.statusbar.StatusBarIconView

import com.android.systemui.statusbar.data.repository.fakeStatusBarModeRepository

import com.android.systemui.statusbar.gesture.SwipeStatusBarAwayGestureHandler

import com.android.systemui.statusbar.notification.collection.notifcollection.CommonNotifCollection

import com.android.systemui.statusbar.notification.data.model.activeNotificationModel

import com.android.systemui.statusbar.notification.data.repository.ActiveNotificationsStore

import com.android.systemui.statusbar.notification.data.repository.activeNotificationListRepository
@@ -76,9 +74,8 @@ import org.mockito.kotlin.whenever 
@RunWith(AndroidJUnit4::class)

@TestableLooper.RunWithLooper

@OptIn(ExperimentalCoroutinesApi::class)

@EnableFlags(FLAG_STATUS_BAR_USE_REPOS_FOR_CALL_CHIP)

@DisableFlags(StatusBarChipsModernization.FLAG_NAME)

class OngoingCallControllerViaRepoTest : SysuiTestCase() {

class OngoingCallControllerTest : SysuiTestCase() {

    private val kosmos = Kosmos()



    private val clock = kosmos.fakeSystemClock
@@ -114,7 +111,6 @@ class OngoingCallControllerViaRepoTest : SysuiTestCase() { 
                testScope.backgroundScope,

                context,

                ongoingCallRepository,

                mock<CommonNotifCollection>(),

                kosmos.activeNotificationsInteractor,

                clock,

                mockActivityStarter,