Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2cc1df04 authored by Vasu Nori's avatar Vasu Nori
Browse files

print finalizer warning before closing the cursor in finalize 

this will let us know which cursor is being finalized.
if the heapworker gets wedbed due to the close bug:2536922
then we will never see the warning and never know which cursor
caused this problem

Change-Id: I595cc1014ff7a1114079b33665c092c6a2f3a907
parent 89206fdb

core/java/android/database/sqlite/SQLiteCursor.java

+4 −2
Original line number Diff line number Diff line
@@ -579,10 +579,12 @@ public class SQLiteCursor extends AbstractWindowedCursor { 
        try {

            // if the cursor hasn't been closed yet, close it first

            if (mWindow != null) {

                close();

                int len = mQuery.mSql.length();

                Log.e(TAG, "Finalizing a Cursor that has not been deactivated or closed. " +

                        "database = " + mDatabase.getPath() + ", table = " + mEditTable +

                        ", query = " + mQuery.mSql, mStackTrace);

                        ", query = " + mQuery.mSql.substring(0, (len > 100) ? 100 : len),

                        mStackTrace);

                close();

                SQLiteDebug.notifyActiveCursorFinalized();

            } else {

                if (Config.LOGV) {