Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ca72c47 authored by Josh Gao's avatar Josh Gao Committed by Android (Google) Code Review
Browse files

Merge changes I9acb1145,Ie1bc4a92 into rvc-dev 

* changes:
  UsbDebuggingActivity: notify failure in onDestroy, not onStop.
  AdbDebuggingManager: improve logging.
parents 7d42405b 7b667835

packages/SystemUI/src/com/android/systemui/usb/UsbDebuggingActivity.java

+6 −1
Original line number Diff line number Diff line
@@ -139,13 +139,18 @@ public class UsbDebuggingActivity extends AlertActivity 
        if (mDisconnectedReceiver != null) {

            mBroadcastDispatcher.unregisterReceiver(mDisconnectedReceiver);

        }

        super.onStop();

    }



    @Override

    protected void onDestroy() {

        // If the ADB service has not yet been notified due to this dialog being closed in some

        // other way then notify the service to deny the connection to ensure system_server sends

        // a response to adbd.

        if (!mServiceNotified) {

            notifyService(false);

        }

        super.onStop();

        super.onDestroy();

    }



    @Override

services/core/java/com/android/server/adb/AdbDebuggingManager.java

+2 −1
Original line number Diff line number Diff line
@@ -878,6 +878,7 @@ public class AdbDebuggingManager { 


                case MESSAGE_ADB_DENY:

                    if (mThread != null) {

                        Slog.w(TAG, "Denying adb confirmation");

                        mThread.sendResponse("NO");

                        logAdbConnectionChanged(null, AdbProtoEnums.USER_DENIED, false);

                    }
@@ -887,7 +888,7 @@ public class AdbDebuggingManager { 
                    String key = (String) msg.obj;

                    if ("trigger_restart_min_framework".equals(

                            SystemProperties.get("vold.decrypt"))) {

                        Slog.d(TAG, "Deferring adb confirmation until after vold decrypt");

                        Slog.w(TAG, "Deferring adb confirmation until after vold decrypt");

                        if (mThread != null) {

                            mThread.sendResponse("NO");

                            logAdbConnectionChanged(key, AdbProtoEnums.DENIED_VOLD_DECRYPT, false);