Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c98fc42 authored by Tim Peng's avatar Tim Peng
Browse files

Add null object checking 

-Add test case

Bug: 151942785
Test: make -j50 RunSettingsLibRoboTests
Change-Id: I707ea48a8e33c300774b12721daa48ced8fc0551
parent 6a68d3d8

packages/SettingsLib/src/com/android/settingslib/media/LocalMediaManager.java

+3 −2
Original line number Diff line number Diff line
@@ -440,8 +440,9 @@ public class LocalMediaManager implements BluetoothCallback { 
            MediaDevice connectDevice = getMediaDeviceById(mMediaDevices, id);

            connectDevice = connectDevice != null

                    ? connectDevice : updateCurrentConnectedDevice();

            if (connectDevice != null) {

                connectDevice.setState(MediaDeviceState.STATE_CONNECTED);



            }

            if (connectDevice == mCurrentConnectedDevice) {

                Log.d(TAG, "onConnectedDeviceChanged() this device all ready connected!");

                return;

packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/LocalMediaManagerTest.java

+6 −0
Original line number Diff line number Diff line
@@ -449,6 +449,12 @@ public class LocalMediaManagerTest { 
                .STATE_CONNECTED);

    }



    @Test

    public void onConnectedDeviceChanged_nullConnectedDevice_noException() {

        mLocalMediaManager.registerCallback(mCallback);

        mLocalMediaManager.mMediaDeviceCallback.onConnectedDeviceChanged(TEST_DEVICE_ID_2);

    }



    @Test

    public void onDeviceAttributesChanged_shouldDispatchDeviceListUpdate() {

        mLocalMediaManager.registerCallback(mCallback);