Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2be6cfe7 authored by Beverly's avatar Beverly Committed by Matt Pietal
Browse files

NotificationShade should animate away on MODE_UNLOCK_COLLAPSING 

Animate away the NotificationShade - this was mistakenly
removed in ag/14455725

Test: manual, atest BiometricsUnlockControllerTest
Fixes: 197271777

Change-Id: I2accd8bd8975b2d49c1dc91870b7cc8467c5139d
Merged-In: I2accd8bd8975b2d49c1dc91870b7cc8467c5139d
(cherry picked from commit c7df5673)
parent 7694cbfd

packages/SystemUI/src/com/android/systemui/statusbar/phone/BiometricUnlockController.java

+6 −1
Original line number Diff line number Diff line
@@ -116,7 +116,7 @@ public class BiometricUnlockController extends KeyguardUpdateMonitorCallback imp 


    /**

     * Mode in which fingerprint unlocks the device or passive auth (ie face auth) unlocks the

     * device while being requested when keyguard is occluded.

     * device while being requested when keyguard is occluded or showing.

     */

    public static final int MODE_UNLOCK_COLLAPSING = 5;
@@ -425,6 +425,11 @@ public class BiometricUnlockController extends KeyguardUpdateMonitorCallback imp 
                if (!wasDeviceInteractive) {

                    mPendingShowBouncer = true;

                } else {

                    mShadeController.animateCollapsePanels(

                            CommandQueue.FLAG_EXCLUDE_NONE,

                            true /* force */,

                            false /* delayed */,

                            BIOMETRIC_COLLAPSE_SPEEDUP_FACTOR);

                    mPendingShowBouncer = false;

                    mKeyguardViewController.notifyKeyguardAuthenticated(

                            false /* strongAuth */);

packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/BiometricsUnlockControllerTest.java

+20 −0
Original line number Diff line number Diff line
@@ -273,6 +273,26 @@ public class BiometricsUnlockControllerTest extends SysuiTestCase { 
                .isEqualTo(BiometricUnlockController.MODE_SHOW_BOUNCER);

    }



    @Test

    public void onBiometricAuthenticated_onLockScreen() {

        // GIVEN not dozing

        when(mUpdateMonitor.isDeviceInteractive()).thenReturn(true);



        // WHEN we want to unlock collapse

        mBiometricUnlockController.startWakeAndUnlock(

                BiometricUnlockController.MODE_UNLOCK_COLLAPSING);



        // THEN we collpase the panels and notify authenticated

        verify(mShadeController).animateCollapsePanels(

                /* flags */ anyInt(),

                /* force */ eq(true),

                /* delayed */ eq(false),

                /* speedUpFactor */ anyFloat()

        );

        verify(mStatusBarKeyguardViewManager).notifyKeyguardAuthenticated(

                /* strongAuth */ eq(false));

    }



    @Test

    public void onBiometricAuthenticated_whenFace_noBypass_encrypted_doNothing() {

        reset(mUpdateMonitor);