Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b61bddc authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Work around clang-tidy bug in dex_builder.cc. 

Bug: 123880763
Test: build with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=*,-readability-*,
    -google-readability-*,-google-runtime-references,-cppcoreguidelines-*,
    -modernize-*,-llvm-*,-bugprone-narrowing-conversions,
    -misc-non-private-member-variables-in-classes,
    -misc-unused-parameters,-hicpp-*,-fuchsia-*

Change-Id: Ibf80f951ae2369a55570770febe8a1c4422181e1
parent d6471064

startop/view_compiler/Android.bp

+0 −2
Original line number Diff line number Diff line
@@ -58,8 +58,6 @@ cc_library_static { 
        "util.cc",

        "layout_validation.cc",

    ],

    // b/123880763, clang-tidy analyzer has segmentation fault with dex_builder.cc

    tidy_checks: ["-clang-analyzer-*"],

    host_supported: true,

}

startop/view_compiler/dex_builder.cc

+1 −1
Original line number Diff line number Diff line
@@ -426,7 +426,7 @@ void MethodBuilder::EncodeInvoke(const Instruction& instruction, ::art::Instruct 
    // Some of the registers don't fit in the four bit short form of the invoke

    // instruction, so we need to do an invoke/range. To do this, we need to

    // first move all the arguments into contiguous temporary registers.

    std::array<Value, kMaxArgs> scratch{GetScratchRegisters<kMaxArgs>()};

    std::array<Value, kMaxArgs> scratch = GetScratchRegisters<kMaxArgs>();



    const auto& prototype = dex_->GetPrototypeByMethodId(instruction.method_id());

    CHECK(prototype.has_value());