Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ac86880 authored by Nader Jawad's avatar Nader Jawad
Browse files

Removed call to setWillNotCacheDrawing and deprecated it as well as 

willNotCacheDrawing as intermediate caching layers are obsolete since
hardware accelerated rendering was introduced in API 11

ImageView's current implementation of setScaleType would manually
disable it's cache if the ScaleType provided was CENTER. This was end up
not drawing the ImageView if View.LAYER_TYPE_SOFTWARE was configured on
the ImageView as the cache no longer existed. Removed the logic to
conditionally disable the drawing cache and marked
setWillNotCacheDrawing/willNotCacheDrawing as hardware accelerated
rendering makes these facilities obsolete

Fixes: 77653694
Fixes: 72139649
Test: Created a test application with an ImageView and manually set a
ScaleType of CENTER and forced the ImageView to render in a software
layer to confirm that it would render properly with a drawable of the
test application's launcher icon

Change-Id: Ie73b1e0708a265e3cc2cc74ed13539f4219dbd7d
parent 70944c1c

api/current.txt

+2 −2
Original line number Diff line number Diff line
@@ -47882,7 +47882,7 @@ package android.view { 
    method public void setVerticalScrollBarEnabled(boolean);

    method public void setVerticalScrollbarPosition(int);

    method public void setVisibility(int);

    method public void setWillNotCacheDrawing(boolean);

    method public deprecated void setWillNotCacheDrawing(boolean);

    method public void setWillNotDraw(boolean);

    method public void setX(float);

    method public void setY(float);
@@ -47900,7 +47900,7 @@ package android.view { 
    method public void unscheduleDrawable(android.graphics.drawable.Drawable);

    method public final void updateDragShadow(android.view.View.DragShadowBuilder);

    method protected boolean verifyDrawable(android.graphics.drawable.Drawable);

    method public boolean willNotCacheDrawing();

    method public deprecated boolean willNotCacheDrawing();

    method public boolean willNotDraw();

    field public static final int ACCESSIBILITY_LIVE_REGION_ASSERTIVE = 2; // 0x2

    field public static final int ACCESSIBILITY_LIVE_REGION_NONE = 0; // 0x0

core/java/android/view/View.java

+28 −0
Original line number Diff line number Diff line
@@ -10398,7 +10398,21 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
     *

     * @param willNotCacheDrawing true if this view does not cache its

     *        drawing, false otherwise

     *

     * @deprecated The view drawing cache was largely made obsolete with the introduction of

     * hardware-accelerated rendering in API 11. With hardware-acceleration, intermediate cache

     * layers are largely unnecessary and can easily result in a net loss in performance due to the

     * cost of creating and updating the layer. In the rare cases where caching layers are useful,

     * such as for alpha animations, {@link #setLayerType(int, Paint)} handles this with hardware

     * rendering. For software-rendered snapshots of a small part of the View hierarchy or

     * individual Views it is recommended to create a {@link Canvas} from either a {@link Bitmap} or

     * {@link android.graphics.Picture} and call {@link #draw(Canvas)} on the View. However these

     * software-rendered usages are discouraged and have compatibility issues with hardware-only

     * rendering features such as {@link android.graphics.Bitmap.Config#HARDWARE Config.HARDWARE}

     * bitmaps, real-time shadows, and outline clipping. For screenshots of the UI for feedback

     * reports or unit testing the {@link PixelCopy} API is recommended.

     */

    @Deprecated

    public void setWillNotCacheDrawing(boolean willNotCacheDrawing) {

        setFlags(willNotCacheDrawing ? WILL_NOT_CACHE_DRAWING : 0, WILL_NOT_CACHE_DRAWING);

    }
@@ -10407,8 +10421,22 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
     * Returns whether or not this View can cache its drawing or not.

     *

     * @return true if this view does not cache its drawing, false otherwise

     *

     * @deprecated The view drawing cache was largely made obsolete with the introduction of

     * hardware-accelerated rendering in API 11. With hardware-acceleration, intermediate cache

     * layers are largely unnecessary and can easily result in a net loss in performance due to the

     * cost of creating and updating the layer. In the rare cases where caching layers are useful,

     * such as for alpha animations, {@link #setLayerType(int, Paint)} handles this with hardware

     * rendering. For software-rendered snapshots of a small part of the View hierarchy or

     * individual Views it is recommended to create a {@link Canvas} from either a {@link Bitmap} or

     * {@link android.graphics.Picture} and call {@link #draw(Canvas)} on the View. However these

     * software-rendered usages are discouraged and have compatibility issues with hardware-only

     * rendering features such as {@link android.graphics.Bitmap.Config#HARDWARE Config.HARDWARE}

     * bitmaps, real-time shadows, and outline clipping. For screenshots of the UI for feedback

     * reports or unit testing the {@link PixelCopy} API is recommended.

     */

    @ViewDebug.ExportedProperty(category = "drawing")

    @Deprecated

    public boolean willNotCacheDrawing() {

        return (mViewFlags & WILL_NOT_CACHE_DRAWING) == WILL_NOT_CACHE_DRAWING;

    }

core/java/android/widget/ImageView.java

+0 −2
Original line number Diff line number Diff line
@@ -817,8 +817,6 @@ public class ImageView extends View { 
        if (mScaleType != scaleType) {

            mScaleType = scaleType;



            setWillNotCacheDrawing(mScaleType == ScaleType.CENTER);



            requestLayout();

            invalidate();

        }