Commit 2abe8aa3 authored Feb 26, 2024 by Cosmin Băieș

Fix IME nav bar long click accessibility toggle

The buttons drawn in the IME nav bar (IME collapse and IME switcher) are
incorrectly set as longClickable (as View#setOnLongClickListener sets
this property to true even when the passed in argument is null).

This lead to Switch Access for accesibility showing a menu with both
Select and Touch & Hold options, but the latter would have no effect.
Instead, we now correctly set these buttons as not longClickable, which
omits showing the menu, and executes the Select action directly.

Test: n/a
Bug: 315723734
Change-Id: I4241d8dee0bea238cd73161a7d8713a03db48ee8

parent 9327855e

core/java/android/inputmethodservice/navigationbar/NavigationBarView.java

+5 −1

Original line number	Diff line number	Diff line
		@@ -99,7 +99,11 @@ public final class NavigationBarView extends FrameLayout {

		mDeadZone = new android.inputmethodservice.navigationbar.DeadZone(this);

		getImeSwitchButton().setOnClickListener(view -> view.getContext()
		getBackButton().setLongClickable(false);

		final ButtonDispatcher imeSwitchButton = getImeSwitchButton();
		imeSwitchButton.setLongClickable(false);
		imeSwitchButton.setOnClickListener(view -> view.getContext()
		.getSystemService(InputMethodManager.class).showInputMethodPicker());
		}