Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a7fd461 authored by Cosmin Băieș's avatar Cosmin Băieș
Browse files

PHASE_IME_APPLY_VISIBILITY_INSETS_CONSUMER timeout 

Fixes a timeout at PHASE_IME_APPLY_VISIBILITY_INSETS_CONSUMER by moving
the progress call into the InputMethodPrivilegedOperations, and adding a
fail call as well.

Test: n/a
Bug: 292092249
Change-Id: If7472c9ce408d58784b80f4cf1e3ae039c282986
parent 706c4bcf

core/java/android/inputmethodservice/InputMethodService.java

+0 −2
Original line number Diff line number Diff line
@@ -2986,8 +2986,6 @@ public class InputMethodService extends AbstractInputMethodService { 
        ImeTracing.getInstance().triggerServiceDump(

                "InputMethodService#applyVisibilityInInsetsConsumerIfNecessary", mDumper,

                null /* icProto */);

        ImeTracker.forLogging().onProgress(mCurStatsToken,

                ImeTracker.PHASE_IME_APPLY_VISIBILITY_INSETS_CONSUMER);

        mPrivOps.applyImeVisibilityAsync(setVisible

                ? mCurShowInputToken : mCurHideInputToken, setVisible, mCurStatsToken);

    }

core/java/com/android/internal/inputmethod/InputMethodPrivilegedOperations.java

+4 −0
Original line number Diff line number Diff line
@@ -386,8 +386,12 @@ public final class InputMethodPrivilegedOperations { 
            @Nullable ImeTracker.Token statsToken) {

        final IInputMethodPrivilegedOperations ops = mOps.getAndWarnIfNull();

        if (ops == null) {

            ImeTracker.forLogging().onFailed(statsToken,

                    ImeTracker.PHASE_IME_APPLY_VISIBILITY_INSETS_CONSUMER);

            return;

        }

        ImeTracker.forLogging().onProgress(statsToken,

                ImeTracker.PHASE_IME_APPLY_VISIBILITY_INSETS_CONSUMER);

        try {

            ops.applyImeVisibilityAsync(showOrHideInputToken, setVisible, statsToken);

        } catch (RemoteException e) {