Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29a0bb92 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge changes I9ff5e6fd,I753c0ba0 

* changes:
  Call prepareSurfaces in applySurfacesChangesTransaction
  Revert "Revert "Avoid setting size/position on Transaction if not needed""
parents 6f1b1c88 6b0f8461

services/core/java/com/android/server/wm/DisplayContent.java

+2 −34
Original line number Diff line number Diff line
@@ -336,9 +336,6 @@ class DisplayContent extends WindowContainer<DisplayContent.DisplayChildWindowCo 
            new TaskForResizePointSearchResult();

    private final ApplySurfaceChangesTransactionState mTmpApplySurfaceChangesTransactionState =

            new ApplySurfaceChangesTransactionState();

    private final ScreenshotApplicationState mScreenshotApplicationState =

            new ScreenshotApplicationState();

    private final Transaction mTmpTransaction = new Transaction();



    // True if this display is in the process of being removed. Used to determine if the removal of

    // the display's direct children should be allowed.
@@ -655,10 +652,7 @@ class DisplayContent extends WindowContainer<DisplayContent.DisplayChildWindowCo 
            mWallpaperController.updateWallpaperVisibility();

        }



        // Use mTmpTransaction instead of mPendingTransaction because we don't want to commit

        // other changes in mPendingTransaction at this point.

        w.handleWindowMovedIfNeeded(mTmpTransaction);

        SurfaceControl.mergeToGlobalTransaction(mTmpTransaction);

        w.handleWindowMovedIfNeeded(mPendingTransaction);



        final WindowStateAnimator winAnimator = w.mWinAnimator;
@@ -693,33 +687,6 @@ class DisplayContent extends WindowContainer<DisplayContent.DisplayChildWindowCo 
                    }

                }

            }

            final TaskStack stack = w.getStack();

            if (!winAnimator.isWaitingForOpening()

                    || (stack != null && stack.isAnimatingBounds())) {

                // Updates the shown frame before we set up the surface. This is needed

                // because the resizing could change the top-left position (in addition to

                // size) of the window. setSurfaceBoundariesLocked uses mShownPosition to

                // position the surface.

                //

                // If an animation is being started, we can't call this method because the

                // animation hasn't processed its initial transformation yet, but in general

                // we do want to update the position if the window is animating. We make an exception

                // for the bounds animating state, where an application may have been waiting

                // for an exit animation to start, but instead enters PiP. We need to ensure

                // we always recompute the top-left in this case.

                winAnimator.computeShownFrameLocked();

            }

            winAnimator.setSurfaceBoundariesLocked(mTmpRecoveringMemory /* recoveringMemory */);



            // Since setSurfaceBoundariesLocked applies the clipping, we need to apply the position

            // to the surface of the window container and also the position of the stack window

            // container as well. Use mTmpTransaction instead of mPendingTransaction to avoid

            // committing any existing changes in there.

            w.updateSurfacePosition(mTmpTransaction);

            if (stack != null) {

                stack.updateSurfaceBounds(mTmpTransaction);

            }

            SurfaceControl.mergeToGlobalTransaction(mTmpTransaction);

        }



        final AppWindowToken atoken = w.mAppToken;
@@ -2822,6 +2789,7 @@ class DisplayContent extends WindowContainer<DisplayContent.DisplayChildWindowCo 


        mTmpRecoveringMemory = recoveringMemory;

        forAllWindows(mApplySurfaceChangesTransaction, true /* traverseTopToBottom */);

        prepareSurfaces();



        mService.mDisplayManagerInternal.setDisplayProperties(mDisplayId,

                mTmpApplySurfaceChangesTransactionState.displayHasContent,

services/core/java/com/android/server/wm/TaskStack.java

+9 −1
Original line number Diff line number Diff line
@@ -44,6 +44,7 @@ import static com.android.server.wm.proto.StackProto.WINDOW_CONTAINER; 


import android.annotation.CallSuper;

import android.content.res.Configuration;

import android.graphics.Point;

import android.graphics.Rect;

import android.graphics.Region;

import android.os.RemoteException;
@@ -145,6 +146,7 @@ public class TaskStack extends WindowContainer<Task> implements 
     * For {@link #prepareSurfaces}.

     */

    final Rect mTmpDimBoundsRect = new Rect();

    private final Point mLastSurfaceSize = new Point();



    TaskStack(WindowManagerService service, int stackId, StackWindowController controller) {

        super(service);
@@ -744,7 +746,13 @@ public class TaskStack extends WindowContainer<Task> implements 
        }



        final Rect stackBounds = getBounds();

        transaction.setSize(mSurfaceControl, stackBounds.width(), stackBounds.height());

        final int width = stackBounds.width();

        final int height = stackBounds.height();

        if (width == mLastSurfaceSize.x && height == mLastSurfaceSize.y) {

            return;

        }

        transaction.setSize(mSurfaceControl, width, height);

        mLastSurfaceSize.set(width, height);

    }



    @Override

services/core/java/com/android/server/wm/WindowContainer.java

+6 −0
Original line number Diff line number Diff line
@@ -95,6 +95,7 @@ class WindowContainer<E extends WindowContainer> extends ConfigurationContainer< 
    protected final WindowManagerService mService;



    private final Point mTmpPos = new Point();

    protected final Point mLastSurfacePosition = new Point();



    /** Total number of elements in this subtree, including our own hierarchy element. */

    private int mTreeWeight = 1;
@@ -1178,7 +1179,12 @@ class WindowContainer<E extends WindowContainer> extends ConfigurationContainer< 
        }



        getRelativePosition(mTmpPos);

        if (mTmpPos.equals(mLastSurfacePosition)) {

            return;

        }



        transaction.setPosition(mSurfaceControl, mTmpPos.x, mTmpPos.y);

        mLastSurfacePosition.set(mTmpPos.x, mTmpPos.y);



        for (int i = mChildren.size() - 1; i >= 0; i--) {

            mChildren.get(i).updateSurfacePosition(transaction);

services/core/java/com/android/server/wm/WindowState.java

+3 −1
Original line number Diff line number Diff line
@@ -4487,6 +4487,7 @@ class WindowState extends WindowContainer<WindowState> implements WindowManagerP 


        // Leash is now responsible for position, so set our position to 0.

        t.setPosition(mSurfaceControl, 0, 0);

        mLastSurfacePosition.set(0, 0);

    }



    @Override
@@ -4502,8 +4503,9 @@ class WindowState extends WindowContainer<WindowState> implements WindowManagerP 
        }



        transformFrameToSurfacePosition(mFrame.left, mFrame.top, mSurfacePosition);

        if (!mSurfaceAnimator.hasLeash()) {

        if (!mSurfaceAnimator.hasLeash() && !mLastSurfacePosition.equals(mSurfacePosition)) {

            t.setPosition(mSurfaceControl, mSurfacePosition.x, mSurfacePosition.y);

            mLastSurfacePosition.set(mSurfacePosition.x, mSurfacePosition.y);

        }

    }