Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2864475f authored by Joshua Trask's avatar Joshua Trask
Browse files

Ignore some Chooser tests that flake on races. 

As described in b/222124533, the reliability of these tests
can be improved with a timeout, but that's still not a very
solid fix. We should just ignore them for now so they stop
breaking on the monitor, and meanwhile I'll continue
investigating the root cause.

Bug: 222124533, 220337209, 220959679, 218218953
Test: disabling tests only
Change-Id: I113a1ba4de2176e209339a1cbbe2583cb5fe518c
parent 07761ee5

core/tests/coretests/src/com/android/internal/app/ChooserActivityTest.java

+6 −3
Original line number Diff line number Diff line
@@ -81,7 +81,6 @@ import android.net.Uri; 
import android.os.UserHandle;

import android.provider.DeviceConfig;

import android.service.chooser.ChooserTarget;

import android.util.Log;

import android.view.View;



import androidx.annotation.CallSuper;
@@ -2072,7 +2071,7 @@ public class ChooserActivityTest { 
                .check(matches(isDisplayed()));

    }



    @Test

    @Test @Ignore("b/222124533")

    public void testAppTargetLogging() throws InterruptedException {

        Intent sendIntent = createSendTextIntent();

        List<ResolvedComponentInfo> resolvedComponentInfos = createResolvedComponentsForTest(2);
@@ -2091,6 +2090,10 @@ public class ChooserActivityTest { 
                mActivityRule.launchActivity(Intent.createChooser(sendIntent, null));

        waitForIdle();



        // TODO(b/222124533): other test cases use a timeout to make sure that the UI is fully

        // populated; without one, this test flakes. Ideally we should address the need for a

        // timeout everywhere instead of introducing one to fix this particular test.



        assertThat(activity.getAdapter().getCount(), is(2));

        onView(withIdFromRuntimeResource("profile_button")).check(doesNotExist());
@@ -2373,7 +2376,7 @@ public class ChooserActivityTest { 
        assertThat(logger.numCalls(), is(6));

    }



    @Test

    @Test @Ignore("b/222124533")

    public void testSwitchProfileLogging() throws InterruptedException {

        // enable the work tab feature flag

        ResolverActivity.ENABLE_TABBED_VIEW = true;