Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28149456 authored by Hans Boehm's avatar Hans Boehm Committed by Android (Google) Code Review
Browse files

Merge "Remove most fillInStackTrace() calls from core" into main

parents 2c44495a b819caad

core/java/android/app/ActivityManager.java

+0 −1
Original line number Diff line number Diff line
@@ -5300,7 +5300,6 @@ public class ActivityManager { 
        if (!exported) {

            /*

            RuntimeException here = new RuntimeException("here");

            here.fillInStackTrace();

            Slog.w(TAG, "Permission denied: checkComponentPermission() owningUid=" + owningUid,

                    here);

            */

core/java/android/app/ApplicationPackageManager.java

+0 −1
Original line number Diff line number Diff line
@@ -1835,7 +1835,6 @@ public class ApplicationPackageManager extends PackageManager { 


                if (false) {

                    RuntimeException e = new RuntimeException("here");

                    e.fillInStackTrace();

                    Log.w(TAG, "Getting drawable 0x" + Integer.toHexString(resId)

                                    + " from package " + packageName

                                    + ": app scale=" + r.getCompatibilityInfo().applicationScale

core/java/android/app/LoadedApk.java

+0 −5
Original line number Diff line number Diff line
@@ -1660,7 +1660,6 @@ public final class LoadedApk { 
                        }

                        RuntimeException ex = new IllegalArgumentException(

                                "Originally unregistered here:");

                        ex.fillInStackTrace();

                        rd.setUnregisterLocation(ex);

                        holder.put(r, rd);

                    }
@@ -1860,7 +1859,6 @@ public final class LoadedApk { 
            mInstrumentation = instrumentation;

            mRegistered = registered;

            mLocation = new IntentReceiverLeaked(null);

            mLocation.fillInStackTrace();

        }



        void validate(Context context, Handler activityThread) {
@@ -2000,7 +1998,6 @@ public final class LoadedApk { 
                        }

                        RuntimeException ex = new IllegalArgumentException(

                                "Originally unbound here:");

                        ex.fillInStackTrace();

                        sd.setUnbindLocation(ex);

                        holder.put(c, sd);

                    }
@@ -2076,7 +2073,6 @@ public final class LoadedApk { 
            mActivityThread = activityThread;

            mActivityExecutor = null;

            mLocation = new ServiceConnectionLeaked(null);

            mLocation.fillInStackTrace();

            mFlags = flags;

        }
@@ -2088,7 +2084,6 @@ public final class LoadedApk { 
            mActivityThread = null;

            mActivityExecutor = activityExecutor;

            mLocation = new ServiceConnectionLeaked(null);

            mLocation.fillInStackTrace();

            mFlags = flags;

        }

core/java/android/app/LoaderManager.java

+43 −46
Original line number Diff line number Diff line
@@ -778,7 +778,6 @@ class LoaderManagerImpl extends LoaderManager { 
        if (DEBUG) Log.v(TAG, "Starting in " + this);

        if (mStarted) {

            RuntimeException e = new RuntimeException("here");

            e.fillInStackTrace();

            Log.w(TAG, "Called doStart when already started: " + this, e);

            return;

        }
@@ -796,7 +795,6 @@ class LoaderManagerImpl extends LoaderManager { 
        if (DEBUG) Log.v(TAG, "Stopping in " + this);

        if (!mStarted) {

            RuntimeException e = new RuntimeException("here");

            e.fillInStackTrace();

            Log.w(TAG, "Called doStop when not started: " + this, e);

            return;

        }
@@ -811,7 +809,6 @@ class LoaderManagerImpl extends LoaderManager { 
        if (DEBUG) Log.v(TAG, "Retaining in " + this);

        if (!mStarted) {

            RuntimeException e = new RuntimeException("here");

            e.fillInStackTrace();

            Log.w(TAG, "Called doRetain when not started: " + this, e);

            return;

        }

core/java/android/app/ResourcesManager.java

+0 −3
Original line number Diff line number Diff line
@@ -1186,7 +1186,6 @@ public class ResourcesManager { 
        synchronized (mLock) {

            if (DEBUG) {

                Throwable here = new Throwable();

                here.fillInStackTrace();

                Slog.w(TAG, "!! Create resources for key=" + key, here);

            }
@@ -1207,7 +1206,6 @@ public class ResourcesManager { 
        synchronized (mLock) {

            if (DEBUG) {

                Throwable here = new Throwable();

                here.fillInStackTrace();

                Slog.w(TAG, "!! Get resources for activity=" + activityToken + " key=" + key, here);

            }
@@ -1351,7 +1349,6 @@ public class ResourcesManager { 


                if (DEBUG) {

                    Throwable here = new Throwable();

                    here.fillInStackTrace();

                    Slog.d(TAG, "updating resources override for activity=" + activityToken

                            + " from oldConfig="

                            + Configuration.resourceQualifierString(oldConfig)