Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2808cbc9 authored by Svet Ganov's avatar Svet Ganov Committed by Svetoslav Ganov
Browse files

Fix an accidentally reverted condition 

The conditional was accidentally reversed so bringing it
back to the correct state and also bringing back the security
exception being thrown on violation.

Test: manual

bug:67773960

Change-Id: I1223297b8662e94413cc0bdcbe86089d1af296c2
parent cac60f92

services/core/java/com/android/server/pm/permission/PermissionManagerService.java

+2 −3
Original line number Diff line number Diff line
@@ -620,9 +620,8 @@ public class PermissionManagerService { 
                enforcePermissionCapLocked(info, tree);

                bp = new BasePermission(info.name, tree.getSourcePackageName(),

                        BasePermission.TYPE_DYNAMIC);

            } else if (bp.isDynamic()) {

                // TODO: switch this back to SecurityException

                Slog.wtf(TAG, "Not allowed to modify non-dynamic permission "

            } else if (!bp.isDynamic()) {

                throw new SecurityException("Not allowed to modify non-dynamic permission "

                        + info.name);

            }

            changed = bp.addToTree(fixedLevel, info, tree);