Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 275708c8 authored by Nick Pelly's avatar Nick Pelly
Browse files

Remove timeout support. 



The implementation was guarenteed to cause deadlock when a timeout was set.

Change-Id: I59444ea784eb9057c6c4c9e9123f558b3ef5eef6
Signed-off-by: default avatarNick Pelly <npelly@google.com>
parent 18149c47

core/java/android/nfc/ILlcpServiceSocket.aidl

+0 −2
Original line number Diff line number Diff line
@@ -23,6 +23,4 @@ interface ILlcpServiceSocket 
{

    int accept(int nativeHandle);

    void close(int nativeHandle);

    int getAcceptTimeout(int nativeHandle);

    void setAcceptTimeout(int nativeHandle, int timeout);

}

core/java/android/nfc/ILlcpSocket.aidl

+0 −2
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ interface ILlcpSocket 
    int close(int nativeHandle);

    int connect(int nativeHandle, int sap);

    int connectByName(int nativeHandle, String sn);

    int getConnectTimeout(int nativeHandle);

    int getLocalSap(int nativeHandle);

    int getLocalSocketMiu(int nativeHandle);

    int getLocalSocketRw(int nativeHandle);
@@ -32,5 +31,4 @@ interface ILlcpSocket 
    int getRemoteSocketRw(int nativeHandle);

    int receive(int nativeHandle, out byte[] receiveBuffer);

    int send(int nativeHandle, in byte[] data);

    void setConnectTimeout(int nativeHandle, int timeout);

}
 
 No newline at end of file

core/java/com/android/internal/nfc/LlcpServiceSocket.java

+0 −28
Original line number Diff line number Diff line
@@ -121,34 +121,6 @@ public class LlcpServiceSocket { 


	}



	/**

	 * Set the timeout for the accept request

	 *

	 * @param timeout

	 *            value of the timeout for the accept request

	 */

	public void setAcceptTimeout(int timeout) {

		try {

			mService.setAcceptTimeout(mHandle, timeout);

		} catch (RemoteException e) {

			Log.e(TAG, "RemoteException in setAcceptTimeout(): ", e);

		}

	}



	/**

	 * Get the timeout value of the accept request

	 *

	 * @return mTimeout

	 */

	public int getAcceptTimeout() {

		try {

			return mService.getAcceptTimeout(mHandle);

		} catch (RemoteException e) {

			Log.e(TAG, "RemoteException in getAcceptTimeout(): ", e);

			return 0;

		}

	}



	/**

	 * Close the created Llcp Service socket

	 */

core/java/com/android/internal/nfc/LlcpSocket.java

+0 −28
Original line number Diff line number Diff line
@@ -139,34 +139,6 @@ public class LlcpSocket { 
		}

	}



	/**

	 * Set the timeout for the connect request

	 *

	 * @param timeout

	 *            timeout value for the connect request

	 */

	public void setConnectTimeout(int timeout) {

		try {

			mService.setConnectTimeout(mHandle, timeout);

		} catch (RemoteException e) {

			Log.e(TAG, "RemoteException in setConnectTimeout(): ", e);

		}

	}



	/**

	 * Get the timeout value of the connect request

	 *

	 * @return mTimeout

	 */

	public int getConnectTimeout() {

		try {

			return mService.getConnectTimeout(mHandle);

		} catch (RemoteException e) {

			Log.e(TAG, "RemoteException in getConnectTimeout(): ", e);

			return 0;

		}

	}



	/**

	 * Disconnect request to the connected LLCP socket and close the created

	 * socket.