Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 273a74f5 authored by Brad Ebinger's avatar Brad Ebinger
Browse files

API Review: Clarify deprecated docs and rethrow from system server 

1) Clarify why there are new APIs being added as @deprecated
   (backwards compatibility), and
2) onLineIdentificationSupplementaryServiceResponse should throw
an exception instead of silently failing.

Test: atest CtsTelephonyTestCases FrameworksTelephonyTests
Bug: 149997057
Bug: 143987946
Fixes: 151172761
Merged-In: I5c2bacad43917a6ecad49dcf9d3213b3472534cc
Change-Id: I5c2bacad43917a6ecad49dcf9d3213b3472534cc
parent 54af9046

telephony/java/android/telephony/ims/ImsUtListener.java

+5 −3
Original line number Diff line number Diff line
@@ -49,7 +49,8 @@ public class ImsUtListener { 
     * {@link ImsSsInfo#CLIR_STATUS_TEMPORARILY_RESTRICTED}, and

     * {@link ImsSsInfo#CLIR_STATUS_TEMPORARILY_ALLOWED}.

     * @deprecated Use {@link #onLineIdentificationSupplementaryServiceResponse(int, ImsSsInfo)}

     * instead.

     * instead, this key has been added for backwards compatibility with older proprietary

     * implementations only and is being phased out.

     */

    @Deprecated

    public static final String BUNDLE_KEY_CLIR = "queryClir";
@@ -60,7 +61,8 @@ public class ImsUtListener { 
     * response. The value will be an instance of {@link ImsSsInfo}, which contains the response to

     * the query.

     * @deprecated Use {@link #onLineIdentificationSupplementaryServiceResponse(int, ImsSsInfo)}

     * instead.

     * instead, this key has been added for backwards compatibility with older proprietary

     * implementations only and is being phased out.

     */

    @Deprecated

    public static final String BUNDLE_KEY_SSINFO = "imsSsInfo";
@@ -123,7 +125,7 @@ public class ImsUtListener { 
        try {

            mServiceInterface.lineIdentificationSupplementaryServiceResponse(id, configuration);

        } catch (RemoteException e) {

            Log.w(LOG_TAG, "onLineIdentificationSupplementaryServicesResponse: remote exception");

            e.rethrowFromSystemServer();

        }

    }