Improve priority ordering of apps when performing boot dexopt. (272bf3a2) · Commits · e / os / android_frameworks_base

core/java/android/content/pm/PackageInfo.java

+5 −0

Original line number	Diff line number	Diff line
		@@ -234,6 +234,9 @@ public class PackageInfo implements Parcelable {
		*/
		public int installLocation = INSTALL_LOCATION_INTERNAL_ONLY;

		/** @hide */
		public boolean coreApp;

		/** @hide */
		public boolean requiredForAllUsers;

		@@ -293,6 +296,7 @@ public class PackageInfo implements Parcelable {
		dest.writeTypedArray(reqFeatures, parcelableFlags);
		dest.writeTypedArray(featureGroups, parcelableFlags);
		dest.writeInt(installLocation);
		dest.writeInt(coreApp ? 1 : 0);
		dest.writeInt(requiredForAllUsers ? 1 : 0);
		dest.writeString(restrictedAccountType);
		dest.writeString(requiredAccountType);
		@@ -337,6 +341,7 @@ public class PackageInfo implements Parcelable {
		reqFeatures = source.createTypedArray(FeatureInfo.CREATOR);
		featureGroups = source.createTypedArray(FeatureGroupInfo.CREATOR);
		installLocation = source.readInt();
		coreApp = source.readInt() != 0;
		requiredForAllUsers = source.readInt() != 0;
		restrictedAccountType = source.readString();
		requiredAccountType = source.readString();

core/java/android/content/pm/PackageParser.java

+5 −0

Original line number	Diff line number	Diff line
		@@ -415,6 +415,7 @@ public class PackageParser {
		pi.sharedUserLabel = p.mSharedUserLabel;
		pi.applicationInfo = generateApplicationInfo(p, flags, state, userId);
		pi.installLocation = p.installLocation;
		pi.coreApp = p.coreApp;
		if ((pi.applicationInfo.flags&ApplicationInfo.FLAG_SYSTEM) != 0
		\|\| (pi.applicationInfo.flags&ApplicationInfo.FLAG_UPDATED_SYSTEM_APP) != 0) {
		pi.requiredForAllUsers = p.mRequiredForAllUsers;
		@@ -1384,6 +1385,8 @@ public class PackageParser {
		PARSE_DEFAULT_INSTALL_LOCATION);
		pkg.applicationInfo.installLocation = pkg.installLocation;

		pkg.coreApp = attrs.getAttributeBooleanValue(null, "coreApp", false);

		sa.recycle();

		/* Set the global "forward lock" flag */
		@@ -4267,6 +4270,8 @@ public class PackageParser {

		public int installLocation;

		public boolean coreApp;

		/* An app that's required for all users and cannot be uninstalled for a user */
		public boolean mRequiredForAllUsers;

services/core/java/com/android/server/pm/PackageManagerService.java

+38 −1

Original line number	Diff line number	Diff line
		@@ -4475,12 +4475,26 @@ public class PackageManagerService extends IPackageManager.Stub {
		// Sort apps by importance for dexopt ordering. Important apps are given more priority
		// in case the device runs out of space.
		ArrayList<PackageParser.Package> sortedPkgs = new ArrayList<PackageParser.Package>();
		// Give priority to core apps.
		for (Iterator<PackageParser.Package> it = pkgs.iterator(); it.hasNext();) {
		PackageParser.Package pkg = it.next();
		if (pkg.coreApp) {
		if (DEBUG_DEXOPT) {
		Log.i(TAG, "Adding core app " + sortedPkgs.size() + ": " + pkg.packageName);
		}
		sortedPkgs.add(pkg);
		it.remove();
		}
		}
		// Give priority to system apps that listen for pre boot complete.
		Intent intent = new Intent(Intent.ACTION_PRE_BOOT_COMPLETED);
		HashSet<String> pkgNames = getPackageNamesForIntent(intent);
		for (Iterator<PackageParser.Package> it = pkgs.iterator(); it.hasNext();) {
		PackageParser.Package pkg = it.next();
		if (pkgNames.contains(pkg.packageName)) {
		if (DEBUG_DEXOPT) {
		Log.i(TAG, "Adding pre boot system app " + sortedPkgs.size() + ": " + pkg.packageName);
		}
		sortedPkgs.add(pkg);
		it.remove();
		}
		@@ -4488,7 +4502,21 @@ public class PackageManagerService extends IPackageManager.Stub {
		// Give priority to system apps.
		for (Iterator<PackageParser.Package> it = pkgs.iterator(); it.hasNext();) {
		PackageParser.Package pkg = it.next();
		if (isSystemApp(pkg)) {
		if (isSystemApp(pkg) && !isUpdatedSystemApp(pkg)) {
		if (DEBUG_DEXOPT) {
		Log.i(TAG, "Adding system app " + sortedPkgs.size() + ": " + pkg.packageName);
		}
		sortedPkgs.add(pkg);
		it.remove();
		}
		}
		// Give priority to updated system apps.
		for (Iterator<PackageParser.Package> it = pkgs.iterator(); it.hasNext();) {
		PackageParser.Package pkg = it.next();
		if (isUpdatedSystemApp(pkg)) {
		if (DEBUG_DEXOPT) {
		Log.i(TAG, "Adding updated system app " + sortedPkgs.size() + ": " + pkg.packageName);
		}
		sortedPkgs.add(pkg);
		it.remove();
		}
		@@ -4499,6 +4527,9 @@ public class PackageManagerService extends IPackageManager.Stub {
		for (Iterator<PackageParser.Package> it = pkgs.iterator(); it.hasNext();) {
		PackageParser.Package pkg = it.next();
		if (pkgNames.contains(pkg.packageName)) {
		if (DEBUG_DEXOPT) {
		Log.i(TAG, "Adding boot app " + sortedPkgs.size() + ": " + pkg.packageName);
		}
		sortedPkgs.add(pkg);
		it.remove();
		}
		@@ -4513,6 +4544,9 @@ public class PackageManagerService extends IPackageManager.Stub {
		int i = 0;
		int total = sortedPkgs.size();
		for (PackageParser.Package pkg : sortedPkgs) {
		if (DEBUG_DEXOPT) {
		Log.i(TAG, "Adding app " + sortedPkgs.size() + ": " + pkg.packageName);
		}
		performBootDexOpt(pkg, ++i, total);
		}
		}
		@@ -5136,6 +5170,9 @@ public class PackageManagerService extends IPackageManager.Stub {

		if ((parseFlags&PackageParser.PARSE_IS_SYSTEM) != 0) {
		pkg.applicationInfo.flags \|= ApplicationInfo.FLAG_SYSTEM;
		} else {
		// Only allow system apps to be flagged as core apps.
		pkg.coreApp = false;
		}

		if ((parseFlags&PackageParser.PARSE_IS_PRIVILEGED) != 0) {