Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26217e3b authored by Yao Chen's avatar Yao Chen
Browse files

Disable ScheduledJobConstraintChanged logging for now. 

+ No metrics or experiments are using this atom. Disabling it does not do any harm.
+ This atom is too frequent during boot time and causes socket buffer overflow. Other
  important events from system server may drop.

We can re-enable the logging once we figure out what metrics we are going to have.

Bug: 129954980
Test: manual
Change-Id: I06bb00cc3be58f73cc88f4cd825f2d71d678fb9d
parent 8d3cb6b3

services/core/java/com/android/server/job/controllers/JobStatus.java

+4 −1
Original line number Diff line number Diff line
@@ -104,6 +104,9 @@ public final class JobStatus { 
            | CONSTRAINT_TIMING_DELAY

            | CONSTRAINT_WITHIN_QUOTA;



    // TODO(b/129954980)

    private static final boolean STATS_LOG_ENABLED = false;



    // Soft override: ignore constraints like time that don't affect API availability

    public static final int OVERRIDE_SOFT = 1;

    // Full override: ignore all constraints including API-affecting like connectivity
@@ -1000,7 +1003,7 @@ public final class JobStatus { 
        }

        satisfiedConstraints = (satisfiedConstraints&~constraint) | (state ? constraint : 0);

        mSatisfiedConstraintsOfInterest = satisfiedConstraints & CONSTRAINTS_OF_INTEREST;

        if ((STATSD_CONSTRAINTS_TO_LOG & constraint) != 0) {

        if (STATS_LOG_ENABLED && (STATSD_CONSTRAINTS_TO_LOG & constraint) != 0) {

            StatsLog.write_non_chained(StatsLog.SCHEDULED_JOB_CONSTRAINT_CHANGED,

                    sourceUid, null, getBatteryName(), getProtoConstraint(constraint),

                    state ? StatsLog.SCHEDULED_JOB_CONSTRAINT_CHANGED__STATE__SATISFIED