Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2568de06 authored by Felipe Leme's avatar Felipe Leme
Browse files

Set FIELD_AUTOFILL_NUM_DATASETS to -1 when service return no response. 

Test: adb shell logcat -b events | grep sysui | grep '757,907'
     # while running LoginActivityTest#testAutoFillNoDatasets

Bug: 70241978

Change-Id: I611bd4fa8407b16491f1ae7b859564233fa6ba81
parent 40bf2b0f

proto/src/metrics_constants.proto

+2 −1
Original line number Diff line number Diff line
@@ -3964,7 +3964,8 @@ message MetricsEvent { 
    // Type TYPE_FAILURE: The request failed

    // Package: Package of app that is autofilled

    // Tag FIELD_AUTOFILL_SERVICE: Package of service that processed the request

    // Tag FIELD_AUTOFILL_NUM_DATASETS: The number of datasets returned (only in success case)

    // Tag FIELD_AUTOFILL_NUM_DATASETS: The number of datasets returned in the response, or -1 if

    // the service returned a null response.

    // NOTE: starting on OS P, it also added:

    // Type TYPE_CLOSE: Service returned a null response.

    // Tag FIELD_AUTOFILL_NUM_FIELD_CLASSIFICATION_IDS: if service requested field classification,

services/autofill/java/com/android/server/autofill/Session.java

+3 −0
Original line number Diff line number Diff line
@@ -596,6 +596,9 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState 
            }

            if (response == null) {

                processNullResponseLocked(requestFlags);

                mMetricsLogger.write(newLogMaker(MetricsEvent.AUTOFILL_REQUEST, servicePackageName)

                        .setType(MetricsEvent.TYPE_SUCCESS)

                        .addTaggedData(MetricsEvent.FIELD_AUTOFILL_NUM_DATASETS, -1));

                return;

            }