Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 254c2c99 authored by Felipe Leme's avatar Felipe Leme
Browse files

Added 'oneway' flags on AIDL where appliable. 

Not only if fixes warning about outgoing transactions from system_server
not having the FLAG, but it fixes system crashes when the service
doesn't behave well (for example, if it does not call super.onCreate()
on onCreate().

BUG: 31001899
Test: manually built and ran it

Change-Id: I829ee501edb84bd02a60e8df92f9a0e0d2157887
parent cd09af72

core/java/android/service/autofill/AutoFillService.java

+5 −0
Original line number Diff line number Diff line
@@ -114,6 +114,11 @@ public abstract class AutoFillService extends Service { 


    private HandlerCaller mHandlerCaller;



    /**

     * {@inheritDoc}

     *

     * <strong>NOTE: </strong>if overridden, it must call {@code super.onCreate()}.

     */

    @Override

    public void onCreate() {

        super.onCreate();

core/java/android/service/autofill/IAutoFillCallback.aidl

+1 −1
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ import java.util.List; 
/**

 * @hide

 */

interface IAutoFillCallback {

oneway interface IAutoFillCallback {

    void autofill(in List values);

    void showError(String message);

}

core/java/android/service/autofill/IAutoFillManagerService.aidl

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ import android.os.Bundle; 
 *

 * {@hide}

 */

interface IAutoFillManagerService {

oneway interface IAutoFillManagerService {



    /**

     * Request auto-fill on the top activity of a given user.

core/java/android/service/autofill/IAutoFillService.aidl

+2 −2
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ import com.android.internal.os.IResultReceiver; 
 * @hide

 */

interface IAutoFillService {

    void onConnected();

    void onDisconnected();

    oneway void onConnected();

    oneway void onDisconnected();

    IResultReceiver getAssistReceiver();

}