Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25416e43 authored by Yuichiro Hanada's avatar Yuichiro Hanada
Browse files

Do not check a transition type when setting launcher alpha to 0 during Desktop exit transition. 

Desktop exit transition may have 'TRANSIT_MINIMIZE' custom transition
type which is not caught by isClosingType.
It already checks the necessary and sufficient condition (opening a
laucher and closing a freeform task or a desktop wallpaper), so we don't
need the check for the transition type.

Bug: 401494583
Test: manual - checks there is no flicker showing a launcher at the beginning of the minimization animation
Flag: com.android.window.flags.enable_desktop_windowing_exit_by_minimize_transition_bugfix
Change-Id: Ie207a762732302292c87114ac349276985d4bb54
parent b10a07bd

packages/SystemUI/animation/src/com/android/systemui/animation/RemoteAnimationRunnerCompat.java

+3 −1
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ import static android.view.WindowManager.TRANSIT_OLD_NONE; 
import static android.view.WindowManager.TRANSIT_OPEN;

import static android.view.WindowManager.TRANSIT_TO_BACK;

import static android.view.WindowManager.TRANSIT_TO_FRONT;

import static android.window.DesktopModeFlags.ENABLE_DESKTOP_WINDOWING_EXIT_BY_MINIMIZE_TRANSITION_BUGFIX;

import static android.window.DesktopModeFlags.ENABLE_DESKTOP_WINDOWING_EXIT_TRANSITIONS_BUGFIX;

import static android.window.TransitionInfo.FLAG_IS_WALLPAPER;
@@ -261,7 +262,8 @@ public abstract class RemoteAnimationRunnerCompat extends IRemoteAnimationRunner 
            SurfaceControl.Transaction startTransaction

    ) {

        checkArgument(isOpeningMode(launcherChange.getMode()));

        if (!isClosingType(info.getType())) {

        if (!isClosingType(info.getType())

                && !ENABLE_DESKTOP_WINDOWING_EXIT_BY_MINIMIZE_TRANSITION_BUGFIX.isTrue()) {

            return;

        }

        for (int i = info.getChanges().size() - 1; i >= 0; --i) {