Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 251edda4 authored by Charles Chen's avatar Charles Chen
Browse files

Fix wrong assertions 

Bubble app may not be added to hierarchy at the start.
Update to use #isNonAppWindowInvisible to cover that
scenario.

Test: atest EnterBubbleViaBubbleMenuTest
Fixes: 428028486
Flag: TEST_ONLY
Change-Id: I25e1c0944cee58f1c3a5fc2bc7463d49d975d672
parent f2e3df02

libs/WindowManager/Shell/tests/e2e/bubbles/flicker-explicit/src/com/android/wm/shell/flicker/bubbles/EnterBubbleViaBubbleMenuTest.kt

+4 −3
Original line number Diff line number Diff line
@@ -96,8 +96,9 @@ class EnterBubbleViaBubbleMenuTest : BubbleFlickerTestBase(), BubbleAppBecomesEx 
    @Test

    fun bubbleWindowBecomesVisible() {

        wmTraceSubject

            .skipUntilFirstAssertion()

            .isAboveAppWindowInvisible(ComponentNameMatcher.BUBBLE)

            // Bubble app window may not have been added to WM hierarchy at the start of the

            // transition.

            .isNonAppWindowInvisible(ComponentNameMatcher.BUBBLE)

            .then()

            .isAboveAppWindowVisible(ComponentNameMatcher.BUBBLE)

            .forAllEntries()
@@ -110,7 +111,7 @@ class EnterBubbleViaBubbleMenuTest : BubbleFlickerTestBase(), BubbleAppBecomesEx 
    fun bubbleLayerBecomesVisible() {

        layersTraceSubject

            // Bubble may not appear at the start of the transition.

            .isInvisible(ComponentNameMatcher.BUBBLE, mustExist = false)

            .isInvisible(ComponentNameMatcher.BUBBLE)

            .then()

            .isVisible(ComponentNameMatcher.BUBBLE)

            .forAllEntries()