Commit 24f4c591 authored Apr 15, 2025 by Ben Lin

DragToDesktopTransitionHandler: Set DoNotPip on finishCallback.

When we are "cancelling" a drag-to-desktop by going to split instead,
because home is now on top, the dragged task is now sent to the back. If
the task can PIP, then Core will trigger respective lifecycle/visibility
checks and ends up putting it into PIP instead of enter-split state.

This sets a new WCT, and call #doNotPip on it, and send it as part of
the transition's finishCallback so the system has signal to not enter
the task into PiP in this case.

Bug: 406539545
Test: Manual. Have youtube, play video, drag to enter-split - it no
longer pips.
Flag: EXEMPT bugfix

Change-Id: I3a85f6eac62347c588d7f440edcfb04d5c699108

parent 35b9b241

libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandler.kt

+4 −1

Original line number	Diff line number	Diff line
		@@ -281,7 +281,10 @@ sealed class DragToDesktopTransitionHandler(
		val wct = WindowContainerTransaction()
		restoreWindowOrder(wct, state)
		state.startTransitionFinishTransaction?.apply()
		state.startTransitionFinishCb?.onTransitionFinished(/* wct= */ null)
		val finishWCT = WindowContainerTransaction()
		val taskInfo = state.draggedTaskChange?.taskInfo ?: error("Expected non-null taskInfo")
		finishWCT.setDoNotPip(taskInfo.token)
		state.startTransitionFinishCb?.onTransitionFinished(finishWCT)
		requestSplitFromScaledTask(splitPosition, wct)
		clearState()
		} else if (