Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 247b7ac0 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Remove useless open modes"

parents 210e2f89 4e4a34bc

cmds/incidentd/src/Section.cpp

+1 −1
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ status_t FileSection::Execute(ReportRequestSet* requests) const { 


    // read from mFilename and pump buffer to incident_helper

    status_t err = NO_ERROR;

    int fd = open(mFilename, O_RDONLY, 0444);

    int fd = open(mFilename, O_RDONLY);

    if (fd == -1) {

       ALOGW("FileSection '%s' failed to open file", this->name.string());

       return -errno;

cmds/incidentd/tests/FdBuffer_test.cpp

+1 −1
Original line number Diff line number Diff line
@@ -201,7 +201,7 @@ TEST_F(FdBufferTest, ReadInStreamEmpty) { 


TEST_F(FdBufferTest, ReadInStreamMoreThan4MB) {

    const std::string testFile = kTestDataPath + "morethan4MB.txt";

    int fd = open(testFile.c_str(), O_RDONLY, 0444);

    int fd = open(testFile.c_str(), O_RDONLY);

    ASSERT_NE(fd, -1);

    int pid = fork();

    ASSERT_TRUE(pid != -1);