Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 24220aae authored Apr 14, 2021 by Jeff DeCew

CallStyle actions have minimum width

This ensures that the major action buttons have a minimum visual emphasis in the layout.

Bug: 179178086
Test: manual
Change-Id: I58744ada45d789a9acb53b0f4965354835595b19

parent 208b1b1b

core/java/android/app/Notification.java

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -6103,6 +6103,9 @@ public class Notification implements Parcelable
	button.setImageViewIcon(R.id.action0, action.getIcon());		button.setImageViewIcon(R.id.action0, action.getIcon());
	boolean priority = action.getExtras().getBoolean(CallStyle.KEY_ACTION_PRIORITY);		boolean priority = action.getExtras().getBoolean(CallStyle.KEY_ACTION_PRIORITY);
	button.setBoolean(R.id.action0, "setWrapModePriority", priority);		button.setBoolean(R.id.action0, "setWrapModePriority", priority);
			int minWidthDimen =
			priority ? R.dimen.call_notification_system_action_min_width : 0;
			button.setIntDimen(R.id.action0, "setMinimumWidth", minWidthDimen);
	}		}
	} else {		} else {
	button.setTextViewText(R.id.action0, processTextSpans(		button.setTextViewText(R.id.action0, processTextSpans(

core/java/android/view/View.java

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -26005,6 +26005,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
	*		*
	* @attr ref android.R.styleable#View_minWidth		* @attr ref android.R.styleable#View_minWidth
	*/		*/
			@RemotableViewMethod
	public void setMinimumWidth(int minWidth) {		public void setMinimumWidth(int minWidth) {
	mMinWidth = minWidth;		mMinWidth = minWidth;
	requestLayout();		requestLayout();

core/res/res/values/dimens.xml

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -242,6 +242,9 @@
	this = conversation_content_start (80dp) - button inset (4dp) - action padding (12dp) -->		this = conversation_content_start (80dp) - button inset (4dp) - action padding (12dp) -->
	<dimen name="call_notification_collapsible_indent">64dp</dimen>		<dimen name="call_notification_collapsible_indent">64dp</dimen>

			<!-- The minimum width of the system actions added to the CallStyle notifications. -->
			<dimen name="call_notification_system_action_min_width">100dp</dimen>

	<!-- The size of icons for visual actions in the notification_material_action_list -->		<!-- The size of icons for visual actions in the notification_material_action_list -->
	<dimen name="notification_actions_icon_size">56dp</dimen>		<dimen name="notification_actions_icon_size">56dp</dimen>

core/res/res/values/symbols.xml

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -3126,6 +3126,7 @@
	<java-symbol type="color" name="call_notification_decline_color"/>		<java-symbol type="color" name="call_notification_decline_color"/>
	<java-symbol type="color" name="call_notification_answer_color"/>		<java-symbol type="color" name="call_notification_answer_color"/>
	<java-symbol type="dimen" name="call_notification_collapsible_indent"/>		<java-symbol type="dimen" name="call_notification_collapsible_indent"/>
			<java-symbol type="dimen" name="call_notification_system_action_min_width"/>
	<java-symbol type="drawable" name="ic_call_answer" />		<java-symbol type="drawable" name="ic_call_answer" />
	<java-symbol type="drawable" name="ic_call_answer_video" />		<java-symbol type="drawable" name="ic_call_answer_video" />
	<java-symbol type="drawable" name="ic_call_decline" />		<java-symbol type="drawable" name="ic_call_decline" />