Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23ee5c27 authored by Evan Chen's avatar Evan Chen
Browse files

Fix NPE for CompanionDeviceActivity.setResultAndFinish() 

Fix: 205274846
Test: atest CompanionDeviceManagerTest
Change-Id: Icecd76d6ff5a81afdcdb7d584ae3ecff51ac5dc3
Merged-In: Icecd76d6ff5a81afdcdb7d584ae3ecff51ac5dc3
parent 539da553

packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionDeviceActivity.java

+2 −2
Original line number Diff line number Diff line
@@ -78,6 +78,7 @@ public class CompanionDeviceActivity extends Activity { 


        getWindow().addSystemFlags(SYSTEM_FLAG_HIDE_NON_SYSTEM_OVERLAY_WINDOWS);

        sInstance = this;

        getService().mActivity = this;



        String deviceProfile = getRequest().getDeviceProfile();

        String profilePrivacyDisclaimer = emptyIfNull(getRequest()
@@ -141,8 +142,6 @@ public class CompanionDeviceActivity extends Activity { 
            profileSummary.setVisibility(View.GONE);

        }



        getService().mActivity = this;



        mCancelButton = findViewById(R.id.button_cancel);

        mCancelButton.setOnClickListener(v -> cancel());

    }
@@ -194,6 +193,7 @@ public class CompanionDeviceActivity extends Activity { 
    @Override

    protected void onDestroy() {

        super.onDestroy();

        getService().mActivity = null;

        if (sInstance == this) {

            sInstance = null;

        }

packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionDeviceDiscoveryService.java

+3 −6
Original line number Diff line number Diff line
@@ -258,12 +258,8 @@ public class CompanionDeviceDiscoveryService extends Service { 
        if (!mIsScanning) return;

        mIsScanning = false;



        CompanionDeviceActivity activity = mActivity;

        if (activity != null) {

            if (activity.mDeviceListView != null) {

                activity.mDeviceListView.removeFooterView(activity.mLoadingIndicator);

            }

            mActivity = null;

        if (mActivity != null && mActivity.mDeviceListView != null) {

            mActivity.mDeviceListView.removeFooterView(mActivity.mLoadingIndicator);

        }



        mBluetoothAdapter.cancelDiscovery();
@@ -337,6 +333,7 @@ public class CompanionDeviceDiscoveryService extends Service { 


    void onCancel() {

        if (DEBUG) Log.i(LOG_TAG, "onCancel()");

        mActivity = null;

        mServiceCallback.cancel(true);

    }