Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23d4cd79 authored by Amith Yamasani's avatar Amith Yamasani
Browse files

Add tests for AppOpsService foreground location 

Test transition between different proc states and
verify that the location perm is granted in the
right states.

Bug: 130313658
Test: atest FrameworksServicesTests:AppOpsServiceTest
Change-Id: I8f9789e1699a776a30b2580a606266ec4b72b2d8
parent 3d6d6f00

services/core/java/com/android/server/appop/AppOpsService.java

+4 −2
Original line number Diff line number Diff line
@@ -220,7 +220,8 @@ public class AppOpsService extends IAppOpsService.Stub { 
     * global Settings. Any access to this class or its fields should be done while

     * holding the AppOpsService lock.

     */

    private final class Constants extends ContentObserver {

    @VisibleForTesting

    final class Constants extends ContentObserver {

        // Key names stored in the settings value.

        private static final String KEY_TOP_STATE_SETTLE_TIME = "top_state_settle_time";

        private static final String KEY_FG_SERVICE_STATE_SETTLE_TIME
@@ -305,7 +306,8 @@ public class AppOpsService extends IAppOpsService.Stub { 
        }

    }



    private final Constants mConstants;

    @VisibleForTesting

    final Constants mConstants;



    @VisibleForTesting

    static final class UidState {

services/tests/servicestests/src/com/android/server/appop/AppOpsServiceTest.java

+107 −0
Original line number Diff line number Diff line
@@ -15,8 +15,11 @@ 
 */

package com.android.server.appop;



import static android.app.ActivityManager.PROCESS_STATE_FOREGROUND_SERVICE;

import static android.app.ActivityManager.PROCESS_STATE_FOREGROUND_SERVICE_LOCATION;

import static android.app.AppOpsManager.MODE_ALLOWED;

import static android.app.AppOpsManager.MODE_ERRORED;

import static android.app.AppOpsManager.MODE_FOREGROUND;

import static android.app.AppOpsManager.OP_COARSE_LOCATION;

import static android.app.AppOpsManager.OP_READ_SMS;

import static android.app.AppOpsManager.OP_WIFI_SCAN;
@@ -25,6 +28,7 @@ import static android.app.AppOpsManager.OP_WRITE_SMS; 
import static com.google.common.truth.Truth.assertThat;

import static com.google.common.truth.Truth.assertWithMessage;



import android.app.ActivityManager;

import android.app.AppOpsManager.OpEntry;

import android.app.AppOpsManager.PackageOps;

import android.content.Context;
@@ -37,6 +41,7 @@ import androidx.test.filters.SmallTest; 
import androidx.test.runner.AndroidJUnit4;



import com.android.server.appop.AppOpsService;



import org.junit.Before;

import org.junit.Test;

import org.junit.runner.RunWith;
@@ -222,6 +227,108 @@ public class AppOpsServiceTest { 
        assertThat(getLoggedOps()).isNull();

    }



    private void setupProcStateTests() {

        // For the location proc state tests

        mAppOpsService.setMode(OP_COARSE_LOCATION, mMyUid, mMyPackageName, MODE_FOREGROUND);

        mAppOpsService.mConstants.FG_SERVICE_STATE_SETTLE_TIME = 0;

        mAppOpsService.mConstants.TOP_STATE_SETTLE_TIME = 0;

        mAppOpsService.mConstants.BG_STATE_SETTLE_TIME = 0;

    }



    @Test

    public void testUidProcStateChange_cachedToTopToCached() throws Exception {

        setupProcStateTests();



        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_CACHED_EMPTY);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isNotEqualTo(MODE_ALLOWED);



        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_TOP);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isEqualTo(MODE_ALLOWED);



        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_CACHED_EMPTY);

        // Second time to make sure that settle time is overcome

        Thread.sleep(50);

        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_CACHED_EMPTY);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isNotEqualTo(MODE_ALLOWED);

    }



    @Test

    public void testUidProcStateChange_cachedToFgs() throws Exception {

        setupProcStateTests();



        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_CACHED_EMPTY);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isNotEqualTo(MODE_ALLOWED);



        mAppOpsService.updateUidProcState(mMyUid, PROCESS_STATE_FOREGROUND_SERVICE);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isNotEqualTo(MODE_ALLOWED);

    }



    @Test

    public void testUidProcStateChange_cachedToFgsLocation() throws Exception {

        setupProcStateTests();



        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_CACHED_EMPTY);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isNotEqualTo(MODE_ALLOWED);



        mAppOpsService.updateUidProcState(mMyUid,

                PROCESS_STATE_FOREGROUND_SERVICE_LOCATION);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isEqualTo(MODE_ALLOWED);

    }



    @Test

    public void testUidProcStateChange_topToFgs() throws Exception {

        setupProcStateTests();



        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_CACHED_EMPTY);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isNotEqualTo(MODE_ALLOWED);



        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_TOP);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isEqualTo(MODE_ALLOWED);



        mAppOpsService.updateUidProcState(mMyUid, PROCESS_STATE_FOREGROUND_SERVICE);

        // Second time to make sure that settle time is overcome

        Thread.sleep(50);

        mAppOpsService.updateUidProcState(mMyUid, PROCESS_STATE_FOREGROUND_SERVICE);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isNotEqualTo(MODE_ALLOWED);

    }



    @Test

    public void testUidProcStateChange_topToFgsLocationToFgs() throws Exception {

        setupProcStateTests();



        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_CACHED_EMPTY);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isNotEqualTo(MODE_ALLOWED);



        mAppOpsService.updateUidProcState(mMyUid, ActivityManager.PROCESS_STATE_TOP);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isEqualTo(MODE_ALLOWED);



        mAppOpsService.updateUidProcState(mMyUid, PROCESS_STATE_FOREGROUND_SERVICE_LOCATION);

        // Second time to make sure that settle time is overcome

        Thread.sleep(50);

        mAppOpsService.updateUidProcState(mMyUid, PROCESS_STATE_FOREGROUND_SERVICE_LOCATION);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isEqualTo(MODE_ALLOWED);



        mAppOpsService.updateUidProcState(mMyUid, PROCESS_STATE_FOREGROUND_SERVICE);

        // Second time to make sure that settle time is overcome

        Thread.sleep(50);

        mAppOpsService.updateUidProcState(mMyUid, PROCESS_STATE_FOREGROUND_SERVICE);

        assertThat(mAppOpsService.noteOperation(OP_COARSE_LOCATION, mMyUid, mMyPackageName))

                .isNotEqualTo(MODE_ALLOWED);

    }



    private List<PackageOps> getLoggedOps() {

        return mAppOpsService.getOpsForPackage(mMyUid, mMyPackageName, null /* all ops */);

    }