Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 232a6985 authored by Henrik Hall's avatar Henrik Hall Committed by Jean-Baptiste Queru
Browse files

Fix data type of RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS in RIL. 

Fixing incorrect data type of RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS
in Android RIL.

The Android RIL specifies that the unsolicited response signal
RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS should contain a raw byte
array (ril.h). However, in the implementation of the Java RIL and
the C++ RIL daemon, the data is unpacked as a string. This causes
data delivered from the network stack to be garbled.

Changing so that both the C++ RIL deamon in platform/hardware/ril
and the Java RIL in frameworks/base follows the specification.

Change-Id: I9b9b26d16cd39422c43d9fa7aadfcff3e60c78ae
parent 0a5174a6

telephony/java/com/android/internal/telephony/RIL.java

+1 −1
Original line number Diff line number Diff line
@@ -2329,7 +2329,7 @@ public final class RIL extends BaseCommands implements CommandsInterface { 
            case RIL_UNSOL_RESTRICTED_STATE_CHANGED: ret = responseInts(p); break;

            case RIL_UNSOL_RESPONSE_SIM_STATUS_CHANGED:  ret =  responseVoid(p); break;

            case RIL_UNSOL_RESPONSE_CDMA_NEW_SMS:  ret =  responseCdmaSms(p); break;

            case RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS:  ret =  responseString(p); break;

            case RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS:  ret =  responseRaw(p); break;

            case RIL_UNSOL_CDMA_RUIM_SMS_STORAGE_FULL:  ret =  responseVoid(p); break;

            case RIL_UNSOL_ENTER_EMERGENCY_CALLBACK_MODE: ret = responseVoid(p); break;

            case RIL_UNSOL_CDMA_CALL_WAITING: ret = responseCdmaCallWaiting(p); break;