Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23284076 authored by Eric Biggers's avatar Eric Biggers
Browse files

Make weaverVerify() return a WeaverReadResponse

Currently weaverVerify() translates the WeaverReadResponse into a
VerifyCredentialResponse, including stashing the Weaver secret in
VerifyCredentialResponse#mGatekeeperHAT (despite the name of this field
not matching this use).  In some cases the VerifyCredentialResponse from
weaverVerify() gets used as the final VerifyCredentialResponse, whereas
in other cases the caller just uses it to check the result of the Weaver
operation and then builds the real VerifyCredentialResponse later.

This makes things unnecessarily convoluted.  Instead, make
weaverVerify() just return the WeaverReadResponse and have the callers
handle it appropriately.  No functional change.

Test: atest FrameworksServicesTests:com.android.server.locksettings
Bug: 320392352
Bug: 395976735
Flag: EXEMPT refactor
Change-Id: I965bfc36e8d3f68223819feb8ac29ca933be6668
parent 3cdf8af0
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment