Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22c6f644 authored by Sumedh Sen's avatar Sumedh Sen Committed by Android Build Coastguard Worker
Browse files

Check whether installerPackageName contains only valid characters 

Bug: 341256391
Bug: 307532206
Test: sts-tradefed run sts-dynamic-develop -m CtsSecurityTestCases -t android.security.cts.CVE_2024_0044
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c32cfc60ccf531470f6125b6019d8ab2452b3617)
Merged-In: I74a172c617d6f5b13f0708092156b657b73b5891
Change-Id: I74a172c617d6f5b13f0708092156b657b73b5891
parent efc4710b

services/core/java/com/android/server/pm/PackageInstallerService.java

+7 −2
Original line number Diff line number Diff line
@@ -693,13 +693,18 @@ public class PackageInstallerService extends IPackageInstaller.Stub implements 
        params.appLabel = TextUtils.trimToSize(params.appLabel,

                PackageItemInfo.MAX_SAFE_LABEL_LENGTH);



        // Validate installer package name.

        // Validate requested installer package name.

        if (params.installerPackageName != null && !isValidPackageName(

                params.installerPackageName)) {

            params.installerPackageName = null;

        }



        var requestedInstallerPackageName =

        // Validate installer package name.

        if (installerPackageName != null && !isValidPackageName(installerPackageName)) {

            installerPackageName = null;

        }



        String requestedInstallerPackageName =

                params.installerPackageName != null ? params.installerPackageName

                        : installerPackageName;