Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22b55373 authored by Alec Mouri's avatar Alec Mouri
Browse files

In TransactionFlinger, don't wrap the SurfaceView with an AndroidView 

AndroidView disables fun optimizations like transparent region hints.
The reason why is mysterious, and probably important, but the CL author
didn't investigate :). Regardless, this is just simpler to do.

Bug: 405591499
Flag: EXEMPT TEST_ONLY
Test: builds and run TransactionFlinger
Change-Id: I8603a538c4c1a0bfc4f31b772f30d26f923d23ac
parent 75c82c24

tests/graphics/TransactionFlinger/src/com/android/test/transactionflinger/activities/SceneActivity.kt

+5 −14
Original line number Diff line number Diff line
@@ -24,10 +24,6 @@ import android.view.SurfaceHolder 
import android.view.SurfaceView

import android.view.WindowInsets

import androidx.activity.ComponentActivity

import androidx.activity.compose.setContent

import androidx.compose.foundation.layout.fillMaxSize

import androidx.compose.ui.Modifier

import androidx.compose.ui.viewinterop.AndroidView

import androidx.core.view.WindowCompat

import com.android.test.transactionflinger.Scene
@@ -51,17 +47,12 @@ abstract class SceneActivity : ComponentActivity(), SurfaceHolder.Callback, Vsyn 


        choreographer = Choreographer.getInstance()

        scene = obtainScene()

        setContent {

            AndroidView(

                modifier = Modifier.fillMaxSize(),

                factory = { context ->

                    surfaceView = SurfaceView(context).apply {



        surfaceView = SurfaceView(this).apply {

            holder.addCallback(this@SceneActivity)

        }

                    surfaceView

                }

            )

        }



        setContentView(surfaceView)

    }



    override fun surfaceCreated(holder: SurfaceHolder) {}